From 4a1af46c8ed806fbc51bedfaf79c019b0afa3aa6 Mon Sep 17 00:00:00 2001 From: Stephan Bosch Date: Tue, 12 Dec 2017 21:46:53 +0100 Subject: [PATCH] submission-login: Fix NULL dereference occurring at an invalid reply from the backend server. Problem found by Coverity. --- src/submission-login/submission-proxy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/submission-login/submission-proxy.c b/src/submission-login/submission-proxy.c index 71bfd4b3e8..95774ff8e1 100644 --- a/src/submission-login/submission-proxy.c +++ b/src/submission-login/submission-proxy.c @@ -233,6 +233,8 @@ int submission_proxy_parse_line(struct client *client, const char *line) str_parse_uint(line, &status, &text) < 0 || status < 200 || status >= 560) { invalid_line = TRUE; + } else { + text++; } if (subm_client->proxy_reply_status != 0 && subm_client->proxy_reply_status != status) { @@ -249,7 +251,6 @@ int submission_proxy_parse_line(struct client *client, const char *line) } else { subm_client->proxy_reply_status = status; } - text++; if ((subm_client->proxy_capability & SMTP_CAPABILITY_ENHANCEDSTATUSCODES) != 0)