From 7707c4b35b868eda75b585c863d97726ff23f80f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martti=20Rannanj=C3=A4rvi?= Date: Tue, 14 Feb 2017 10:42:26 +0200 Subject: [PATCH] lib-index: zero mmap_length after logging error Logging that mmap(size=0) failed looks suspicious. --- src/lib-index/mail-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib-index/mail-cache.c b/src/lib-index/mail-cache.c index abdd627c01..e1652323f2 100644 --- a/src/lib-index/mail-cache.c +++ b/src/lib-index/mail-cache.c @@ -480,12 +480,12 @@ int mail_cache_map(struct mail_cache *cache, size_t offset, size_t size, cache->mmap_base = mmap_ro_file(cache->fd, &cache->mmap_length); if (cache->mmap_base == MAP_FAILED) { cache->mmap_base = NULL; - cache->mmap_length = 0; if (ioloop_time != cache->last_mmap_error_time) { cache->last_mmap_error_time = ioloop_time; mail_cache_set_syscall_error(cache, t_strdup_printf( "mmap(size=%"PRIuSIZE_T")", cache->mmap_length)); } + cache->mmap_length = 0; return -1; } *data_r = offset > cache->mmap_length ? NULL :