Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): prevent overwrite of itemRefs when hooks rerender #1219

Merged
merged 1 commit into from Jan 18, 2021

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Jan 17, 2021

What:

Based on #1205 and with some test changes.
Fixes #1178.

Why:

See #1205

How:

See #1205

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@silviuaavram silviuaavram changed the title feat(hooks): dispatch changes only when needed #1218 fix(hooks): prevent overwrite of itemRefs when hooks rerender #1218 Jan 17, 2021
@silviuaavram silviuaavram changed the title fix(hooks): prevent overwrite of itemRefs when hooks rerender #1218 fix(hooks): prevent overwrite of itemRefs when hooks rerender Jan 17, 2021
Copy link
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring!

@silviuaavram silviuaavram merged commit 4b6860e into master Jan 18, 2021
@silviuaavram silviuaavram deleted the pr/1205 branch January 18, 2021 17:56
@github-actions
Copy link

🎉 This PR is included in version 6.0.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disabled prop in getItemProps() breaks React.memo on Item component
2 participants