fix(useCombobox): tab to body should select element #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aliceHendicott can you take a look at this as well, since it's related to your previous fix. Thank you! The issue is attached to the description. |
|
🎉 This PR is included in version 7.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Tabbing with an element highlighted should select that element, even if the combobox is the last element in the tab order and the focus ends up on
body.Why:
Fixes #1515
How:
The bug is a regression from #1484.
The fix in the PR above handles correctly the case when blur is performed by tab change, and in this case the element should not be selected. Blur by tab change is detected via
event.relatedTarget === null. However, tabbing from the last element in the tab order also hasevent.relatedTarget === nullso we need to distinguish between these two cases. The fix is to also check theenvironment.document.activeElement === environment.document.body.Checklist: