Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reactNativeWeb): support in Downshift and hooks #1489

Merged
merged 1 commit into from Mar 20, 2023

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Mar 19, 2023

What:
Support React Native Web in the hooks and in Downshift.

Why:
React Native is supported fully, we also should support React Native Web.

How:
As recommended in #1315 (comment), we will create a react native web build and use the isReactNativeWeb variable to return the correct code in React native web (onPress, event.nativeEvent.text etc).

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4ff1385) 100.00% compared to head (e460a66) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1489   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1703      1703           
  Branches       510       510           
=========================================
  Hits          1703      1703           
Impacted Files Coverage Δ
src/downshift.js 100.00% <100.00%> (ø)
src/hooks/useCombobox/index.js 100.00% <100.00%> (ø)
src/hooks/useSelect/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@DaveWelling DaveWelling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had much success with unit testing react native, so I can understand why there aren't any for this PR. I wish I had this figured out so I could contribute that aspect. Maybe I'll get it worked out in our project at sstid (my work) and then I can contribute some more of that here. In any case it is what it is for now, and FWIW I don't see any obvious problems here.

@silviuaavram silviuaavram merged commit a4c3714 into master Mar 20, 2023
2 checks passed
@silviuaavram silviuaavram deleted the feat/support-react-native-web branch March 20, 2023 07:07
@github-actions
Copy link

🎉 This PR is included in version 7.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants