New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownThemAll! window stuck on "Loading ..." on Firefox 57.0a1 #240

Open
jdrch opened this Issue Aug 6, 2017 · 7 comments

Comments

Projects
None yet
6 participants
@jdrch

jdrch commented Aug 6, 2017

Your DownThemAll! and Browser Version and Language and Operating System

DownThemAll! version: 3.1.1pre.20170731.00h00m36s
Firefox Version: 57.0a1 20170806100257
OS: Windows 10 Pro 64-bit Creator's Update

Expected Behavior

DownThemAll! window loads and commences download

Actual Behavior

DownThemAll! window stuck on Loading... and nothing is downloaded

Steps To Reproduce

  • Right-click on an image or any file link
  • Click Save ... with DownThemAll!
  • Select the download location and click OK
  • The DownThemAll! window will appear with Loading... only, and nothing will actually download

Additional info such as log extracts

Log file:

12:30:46::552
DownThemAll! (debug) - closed a pref window
anonymous @ chrome://dta/content/preferences/prefs.js:592
unloadWindow/handler<() @ chrome://dta-modules/content/support/overlays.js:17
_runUnloader() @ chrome://dta-modules/content/glue.jsm:279
unload/<() @ chrome://dta-modules/content/glue.jsm:361
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1239
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1590
initialize/<() @ chrome://mozapps/content/extensions/extensions.js:144
--> chrome://dta/content/preferences/prefs.js:592:0
12:31:53::576
DownThemAll! (debug) - getting normal history for directory
getHistory() @ chrome://dta-modules/content/support/historymanager.js:131
getDropDownValue() @ chrome://dta-modules/content/api.js:338
turboSendLinksToManager() @ chrome://dta-modules/content/api.js:378
saveSingleItem() @ chrome://dta-modules/content/api.js:352
saveSingleLinkAsync() @ chrome://dta-modules/content/loaders/integration.js:464
--> chrome://dta-modules/content/support/historymanager.js:131:0
12:31:53::578
DownThemAll! (debug) - getting normal history for renaming
getHistory() @ chrome://dta-modules/content/support/historymanager.js:131
getDropDownValue() @ chrome://dta-modules/content/api.js:338
turboSendLinksToManager() @ chrome://dta-modules/content/api.js:379
saveSingleItem() @ chrome://dta-modules/content/api.js:352
saveSingleLinkAsync() @ chrome://dta-modules/content/loaders/integration.js:464
--> chrome://dta-modules/content/support/historymanager.js:131:0
12:31:53::579
DownThemAll! (debug) - manager already pending; queuing
openManager() @ chrome://dta-modules/content/api.js:497
sendLinksToManager() @ chrome://dta-modules/content/api.js:367
turboSendLinksToManager() @ chrome://dta-modules/content/api.js:393
saveSingleItem() @ chrome://dta-modules/content/api.js:352
saveSingleLinkAsync() @ chrome://dta-modules/content/loaders/integration.js:464
--> chrome://dta-modules/content/api.js:497:0
12:31:53::581
DownThemAll! (error) - saveSingleLink [Exception: uri.path is undefined]
_load@chrome://dta-modules/content/utils.js:493:4
mapInSitu@chrome://dta-modules/content/support/uniquelinks.js:39:12
_loadBundles@chrome://dta-modules/content/utils.js:518:16
StringBundles@chrome://dta-modules/content/utils.js:537:20
@chrome://dta-modules/content/loaders/integration.js:20:28
get@resource://gre/modules/XPCOMUtils.jsm:199:21
saveSingleLinkAsync@chrome://dta-modules/content/loaders/integration.js:465:6
asyncfindSingleImg@chrome://dta-modules/content/loaders/integration.js:421:3
initMenusAndCommands/<@chrome://dta-modules/content/loaders/integration.js:1082:29
EventListener.handleEvent
bindEvt/<@chrome://dta-modules/content/loaders/integration.js:1044:5
initMenusAndCommands@chrome://dta-modules/content/loaders/integration.js:1082:4
load@chrome://dta-modules/content/loaders/integration.js:1041:12
fire@chrome://dta-modules/content/main.js:307:4
openPopupAtScreen@chrome://global/content/bindings/popup.xml:83:15
openContextMenu@chrome://browser/content/nsContextMenu.js:76:3
receiveMessage@chrome://browser/content/tabbrowser.xml:5261:15

--> chrome://dta-modules/content/utils.js:493:0
12:31:53::582
DownThemAll! (error) - Failed to process single link [Exception: bundle is not defined]
saveSingleLinkAsync@chrome://dta-modules/content/loaders/integration.js:470:6
asyncfindSingleImg@chrome://dta-modules/content/loaders/integration.js:421:3
initMenusAndCommands/<@chrome://dta-modules/content/loaders/integration.js:1082:29
EventListener.handleEvent
bindEvt/<@chrome://dta-modules/content/loaders/integration.js:1044:5
initMenusAndCommands@chrome://dta-modules/content/loaders/integration.js:1082:4
load@chrome://dta-modules/content/loaders/integration.js:1041:12
fire@chrome://dta-modules/content/main.js:307:4
openPopupAtScreen@chrome://global/content/bindings/popup.xml:83:15
openContextMenu@chrome://browser/content/nsContextMenu.js:76:3
receiveMessage@chrome://browser/content/tabbrowser.xml:5261:15

--> chrome://dta-modules/content/loaders/integration.js:470:0
12:33:12::981
DownThemAll! (debug) - getting normal history for renaming
getHistory() @ chrome://dta-modules/content/support/historymanager.js:131
_load() @ chrome://dta/content/common/bindings.xml:114
saveddropdown_XBL_Constructor() @ chrome://dta/content/common/bindings.xml:80
--> chrome://dta-modules/content/support/historymanager.js:131:0
12:33:12::984
DownThemAll! (debug) - getting normal history for directory
getHistory() @ chrome://dta-modules/content/support/historymanager.js:131
_load() @ chrome://dta/content/common/bindings.xml:114
saveddropdown_XBL_Constructor() @ chrome://dta/content/common/bindings.xml:80
--> chrome://dta-modules/content/support/historymanager.js:131:0
12:33:15::261
DownThemAll! (debug) - manager already pending; queuing
openManager() @ chrome://dta-modules/content/api.js:497
sendLinksToManager() @ chrome://dta-modules/content/api.js:367
sendDownloads() @ chrome://dta/content/dta/addurl.js:355
downloadItem() @ chrome://dta/content/dta/addurl.js:323
download() @ chrome://dta/content/dta/addurl.js:235
anonymous() @ chrome://global/content/bindings/dialog.xml line 379 > Function:3
_fireButtonEvent() @ chrome://global/content/bindings/dialog.xml:380
_doButtonCommand() @ chrome://global/content/bindings/dialog.xml:348
_handleButtonCommand() @ chrome://global/content/bindings/dialog.xml:336
--> chrome://dta-modules/content/api.js:497:0
12:33:15::300
DownThemAll! (debug) - closed an addurl window
anonymous @ chrome://dta/content/dta/addurl.js:374
unloadWindow/handler<() @ chrome://dta-modules/content/support/overlays.js:17
_runUnloader() @ chrome://dta-modules/content/glue.jsm:279
unload/<() @ chrome://dta-modules/content/glue.jsm:361
--> chrome://dta/content/dta/addurl.js:374:0
12:33:32::902
DownThemAll! (debug) - getting normal history for renaming
getHistory() @ chrome://dta-modules/content/support/historymanager.js:131
_load() @ chrome://dta/content/common/bindings.xml:114
saveddropdown_XBL_Constructor() @ chrome://dta/content/common/bindings.xml:80
--> chrome://dta-modules/content/support/historymanager.js:131:0
12:33:32::904
DownThemAll! (debug) - getting normal history for directory
getHistory() @ chrome://dta-modules/content/support/historymanager.js:131
_load() @ chrome://dta/content/common/bindings.xml:114
saveddropdown_XBL_Constructor() @ chrome://dta/content/common/bindings.xml:80
--> chrome://dta-modules/content/support/historymanager.js:131:0
12:33:34::781
DownThemAll! (debug) - manager already pending; queuing
openManager() @ chrome://dta-modules/content/api.js:497
sendLinksToManager() @ chrome://dta-modules/content/api.js:367
sendDownloads() @ chrome://dta/content/dta/addurl.js:355
downloadItem() @ chrome://dta/content/dta/addurl.js:323
download() @ chrome://dta/content/dta/addurl.js:235
anonymous() @ chrome://global/content/bindings/dialog.xml line 379 > Function:3
_fireButtonEvent() @ chrome://global/content/bindings/dialog.xml:380
_doButtonCommand() @ chrome://global/content/bindings/dialog.xml:348
_handleButtonCommand() @ chrome://global/content/bindings/dialog.xml:336
--> chrome://dta-modules/content/api.js:497:0
12:33:34::821
DownThemAll! (debug) - closed an addurl window
anonymous @ chrome://dta/content/dta/addurl.js:374
unloadWindow/handler<() @ chrome://dta-modules/content/support/overlays.js:17
_runUnloader() @ chrome://dta-modules/content/glue.jsm:279
unload/<() @ chrome://dta-modules/content/glue.jsm:361
--> chrome://dta/content/dta/addurl.js:374:0
12:33:51::963
DownThemAll! (debug) - unload stub called
frameToLog() @ chrome://dta-modules/content/main.js:506
--> chrome://dta-modules/content/main.js:506:0
12:33:55::599
DownThemAll! (debug) - getting normal history for filter
getHistory() @ chrome://dta-modules/content/support/historymanager.js:131
getDropDownValue() @ chrome://dta-modules/content/api.js:338
load() @ chrome://dta/content/preferences/prefs.js:34
anonymous() @ chrome://global/content/bindings/preferences.xml line 782 > Function:3
_fireEvent() @ chrome://global/content/bindings/preferences.xml:783
observe() @ chrome://global/content/bindings/preferences.xml:758
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1239
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1590
initialize/<() @ chrome://mozapps/content/extensions/extensions.js:144
--> chrome://dta-modules/content/support/historymanager.js:131:0
12:33:55::600
DownThemAll! (debug) - getting normal history for directory
getHistory() @ chrome://dta-modules/content/support/historymanager.js:131
getDropDownValue() @ chrome://dta-modules/content/api.js:338
load() @ chrome://dta/content/preferences/prefs.js:35
anonymous() @ chrome://global/content/bindings/preferences.xml line 782 > Function:3
_fireEvent() @ chrome://global/content/bindings/preferences.xml:783
observe() @ chrome://global/content/bindings/preferences.xml:758
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1239
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1590
initialize/<() @ chrome://mozapps/content/extensions/extensions.js:144
--> chrome://dta-modules/content/support/historymanager.js:131:0
12:33:57::525
DownThemAll! (info) - Mediator: Request to open file://C:\Users\Judah\AppData\Roaming\Mozilla\Firefox\Profiles\0sb5sg2g.default\downthemall.net\log.txt
openUrl() @ chrome://dta-modules/content/support/mediator.js:140
openUrl() @ chrome://dta/content/common/internalFunctions.js:35
showLog() @ chrome://dta/content/preferences/prefs.js:56
oncommand() @ chrome://dta/content/preferences/prefs.xul:1
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1239
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1590
initialize/<() @ chrome://mozapps/content/extensions/extensions.js:144
--> chrome://dta-modules/content/support/mediator.js:140:0
12:33:58::357
DownThemAll! (debug) - unload stub called
frameToLog() @ chrome://dta-modules/content/main.js:506
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1239
doCommand() @ chrome://mozapps/content/extensions/extensions.js:1590
initialize/<() @ chrome://mozapps/content/extensions/extensions.js:144
--> chrome://dta-modules/content/main.js:506:0
dta loading

@salarcode

This comment has been minimized.

Show comment
Hide comment
@salarcode

salarcode Aug 13, 2017

Starting from Firefox 57, only extensions developed using WebExtensions APIs will be supported

salarcode commented Aug 13, 2017

Starting from Firefox 57, only extensions developed using WebExtensions APIs will be supported

@davidhedlund

This comment has been minimized.

Show comment
Hide comment
@davidhedlund

davidhedlund Sep 2, 2017

DownThemAll and WebExtensions [... or why why I am done with mozilla] - https://mail.mozilla.org/pipermail/dev-addons/2016-December/002367.html

davidhedlund commented Sep 2, 2017

DownThemAll and WebExtensions [... or why why I am done with mozilla] - https://mail.mozilla.org/pipermail/dev-addons/2016-December/002367.html

@ssokolow

This comment has been minimized.

Show comment
Hide comment
@ssokolow

ssokolow Nov 26, 2017

I hope DTA Lite will support the following combination of features:

  • Customizing what gets provided to the downloads API as the suggested filename
  • Providing a monotonic "batch number" counter and "source domain" as tokens that can be used in filename templates
  • Setting the saveAs: false in the download() call.

That way, I can set a {batch_ID}<space>{source_domain}<space>{suggested_filename} pattern and write a PyQt daemon to watch some folder like ~/.downloads which parses filenames and uses the information to reconstruct the following two features externally:

  • Allow each download batch to go to a different folder, but only ask once for the whole batch
  • Remember the last-used download folder separately for each domain (This is actually something that Firefox itself does, but classic dTA doesn't automate, so it'd be an improvement.)

Failing that, I suppose I'll write an extension which integrates an external download manager into Firefox. (Maybe KGet if it has an API that would allow an extension to specify which browser cookies and headers to spoof.)

ssokolow commented Nov 26, 2017

I hope DTA Lite will support the following combination of features:

  • Customizing what gets provided to the downloads API as the suggested filename
  • Providing a monotonic "batch number" counter and "source domain" as tokens that can be used in filename templates
  • Setting the saveAs: false in the download() call.

That way, I can set a {batch_ID}<space>{source_domain}<space>{suggested_filename} pattern and write a PyQt daemon to watch some folder like ~/.downloads which parses filenames and uses the information to reconstruct the following two features externally:

  • Allow each download batch to go to a different folder, but only ask once for the whole batch
  • Remember the last-used download folder separately for each domain (This is actually something that Firefox itself does, but classic dTA doesn't automate, so it'd be an improvement.)

Failing that, I suppose I'll write an extension which integrates an external download manager into Firefox. (Maybe KGet if it has an API that would allow an extension to specify which browser cookies and headers to spoof.)

@ashlord666

This comment has been minimized.

Show comment
Hide comment
@ashlord666

ashlord666 Nov 28, 2017

Wow, looking at the link posted by davidhedlund above, I literally had to facepalm.

There is ONLY ONE reason why I keep firefox installed in my system. When the need arises, I copy a link from chrome and paste it into firefox, right click and use DTA to grab the world. Seems like I should just uninstall ff now.

ashlord666 commented Nov 28, 2017

Wow, looking at the link posted by davidhedlund above, I literally had to facepalm.

There is ONLY ONE reason why I keep firefox installed in my system. When the need arises, I copy a link from chrome and paste it into firefox, right click and use DTA to grab the world. Seems like I should just uninstall ff now.

@HyperScorpio

This comment has been minimized.

Show comment
Hide comment
@HyperScorpio

HyperScorpio Dec 8, 2017

New update of firefox released.

HyperScorpio commented Dec 8, 2017

New update of firefox released.

@davidhedlund

This comment has been minimized.

Show comment
Hide comment
@davidhedlund

davidhedlund Dec 8, 2017

@HyperScorpio Has DownThemAll! been released for Firefox 57? When will the new release be available on AMO (the page still says "Not compatible with Firefox Quantum").

davidhedlund commented Dec 8, 2017

@HyperScorpio Has DownThemAll! been released for Firefox 57? When will the new release be available on AMO (the page still says "Not compatible with Firefox Quantum").

@jdrch

This comment has been minimized.

Show comment
Hide comment
@jdrch

jdrch Dec 11, 2017

Great to hear that a new version of DTA is being worked on at the least.

jdrch commented Dec 11, 2017

Great to hear that a new version of DTA is being worked on at the least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment