Skip to content

Commit 15c3bb2

Browse files
committed
issue #11128 Unknown anchors in code
1 parent 7e18605 commit 15c3bb2

File tree

4 files changed

+10
-65
lines changed

4 files changed

+10
-65
lines changed

src/docsets.cpp

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -333,17 +333,8 @@ void DocSets::addIndexItem(const Definition *context,const MemberDef *md,
333333
case SrcLangExt::Unknown: lang="unknown"; break; // should not happen!
334334
}
335335

336-
if (md)
336+
if (context && md)
337337
{
338-
if (context==nullptr)
339-
{
340-
if (md->getGroupDef())
341-
context = md->getGroupDef();
342-
else if (md->getFileDef())
343-
context = md->getFileDef();
344-
}
345-
if (context==nullptr) return; // should not happen
346-
347338
switch (md->memberType())
348339
{
349340
case MemberType::Define:
@@ -402,16 +393,7 @@ void DocSets::addIndexItem(const Definition *context,const MemberDef *md,
402393
case MemberType::Dictionary:
403394
type="dictionary"; break;
404395
}
405-
cd = md->getClassDef();
406-
nd = md->getNamespaceDef();
407-
if (cd)
408-
{
409-
scope = cd->qualifiedName();
410-
}
411-
else if (nd)
412-
{
413-
scope = nd->name();
414-
}
396+
scope = md->getScopeString();
415397
fd = md->getFileDef();
416398
if (fd)
417399
{

src/htmlhelp.cpp

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -602,28 +602,15 @@ void HtmlHelp::addContentsItem(bool isDir,
602602
void HtmlHelp::addIndexItem(const Definition *context,const MemberDef *md,
603603
const QCString &sectionAnchor,const QCString &word)
604604
{
605-
if (md)
605+
if (context && md)
606606
{
607-
bool separateMemberPages = Config_getBool(SEPARATE_MEMBER_PAGES);
608-
if (context==nullptr) // global member
609-
{
610-
if (md->getGroupDef())
611-
context = md->getGroupDef();
612-
else if (md->getFileDef())
613-
context = md->getFileDef();
614-
}
615-
if (context==nullptr) return; // should not happen
616-
617607
QCString cfname = md->getOutputFileBase();
618608
QCString argStr = md->argsString();
619-
QCString cfiname = context->getOutputFileBase();
620609
QCString level1 = context->name();
621610
QCString level2 = md->name() + argStr;
622-
QCString contRef = separateMemberPages ? cfname : cfiname;
623-
QCString memRef = cfname;
624611
QCString anchor = !sectionAnchor.isEmpty() ? sectionAnchor : md->anchor();
625-
p->index.addItem(level1,level2,contRef,anchor,TRUE,FALSE);
626-
p->index.addItem(level2,level1,memRef,anchor,TRUE,TRUE);
612+
p->index.addItem(level1,level2,cfname,anchor,TRUE,FALSE);
613+
p->index.addItem(level2,level1,cfname,anchor,TRUE,TRUE);
627614
}
628615
else if (context)
629616
{

src/qhp.cpp

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ void Qhp::addContentsItem(bool /* isDir */, const QCString & name,
350350
blank << "<title>Validator / crawler helper</title>\n";
351351
blank << "<meta http-equiv=\"Content-Type\" content=\"text/xhtml;charset=UTF-8\"/>\n";
352352
blank << "<meta http-equiv=\"X-UA-Compatible\" content=\"IE=11\"/>\n";
353-
353+
354354
blank << "<meta name=\"generator\" content=\"Doxygen " + getDoxygenVersion() + "\"/>\n";
355355
blank << "<meta name=\"viewport\" content=\"width=device-width, initial-scale=1\"/>\n";
356356
blank << "</head>\n";
@@ -375,28 +375,17 @@ void Qhp::addIndexItem(const Definition *context,const MemberDef *md,
375375
// md?md->name().data():"<none>",
376376
// qPrint(word));
377377

378-
if (md) // member
378+
if (context && md) // member
379379
{
380-
bool separateMemberPages = Config_getBool(SEPARATE_MEMBER_PAGES);
381-
if (context==nullptr) // global member
382-
{
383-
if (md->getGroupDef())
384-
context = md->getGroupDef();
385-
else if (md->getFileDef())
386-
context = md->getFileDef();
387-
}
388-
if (context==nullptr) return; // should not happen
389380
QCString cfname = md->getOutputFileBase();
390381
QCString argStr = md->argsString();
391-
QCString cfiname = context->getOutputFileBase();
392382
QCString level1 = context->name();
393383
QCString level2 = !word.isEmpty() ? word : md->name();
394-
QCString contRef = separateMemberPages ? cfname : cfiname;
395384
QCString anchor = !sectionAnchor.isEmpty() ? sectionAnchor : md->anchor();
396385
QCString ref;
397386

398387
// <keyword name="foo" id="MyApplication::foo" ref="doc.html#foo"/>
399-
ref = makeRef(contRef, anchor);
388+
ref = makeRef(cfname, anchor);
400389
QCString id = level1+"::"+level2;
401390
writeIndent(p->index,3);
402391
p->index << "<keyword name=\"" << convertToXML(level2 + argStr) << "\""

src/sitemap.cpp

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -189,28 +189,15 @@ static QCString makeRef(const QCString & withoutExtension, const QCString & anch
189189
if (anchor.isEmpty()) return result;
190190
return result+"#"+anchor;
191191
}
192+
192193
void Crawlmap::addIndexItem(const Definition *context, const MemberDef *md,
193194
const QCString &sectionAnchor, const QCString &title)
194195
{
195196
if (md) // member
196197
{
197-
bool separateMemberPages = Config_getBool(SEPARATE_MEMBER_PAGES);
198-
if (context==nullptr) // global member
199-
{
200-
if (md->getGroupDef())
201-
context = md->getGroupDef();
202-
else if (md->getFileDef())
203-
context = md->getFileDef();
204-
}
205-
if (context==nullptr) return; // should not happen
206198
QCString cfname = md->getOutputFileBase();
207-
//QCString argStr = md->argsString();
208-
QCString cfiname = context->getOutputFileBase();
209-
QCString contRef = separateMemberPages ? cfname : cfiname;
210199
QCString anchor = !sectionAnchor.isEmpty() ? sectionAnchor : md->anchor();
211-
QCString ref;
212-
213-
ref = makeRef(contRef, anchor);
200+
QCString ref = makeRef(cfname, anchor);
214201
p->crawlLinks.insert(ref.str());
215202
}
216203
else if (context) // container

0 commit comments

Comments
 (0)