Skip to content

Commit 265b08e

Browse files
committed
Performance improvement by returning BaseClassList by reference
1 parent 42bac34 commit 265b08e

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/classdef.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,9 @@ class ClassDefImpl : public DefinitionMixin<ClassDefMutable>
177177
virtual QCString displayName(bool includeScope=TRUE) const;
178178
virtual CompoundType compoundType() const;
179179
virtual QCString compoundTypeString() const;
180-
virtual BaseClassList baseClasses() const;
180+
virtual const BaseClassList &baseClasses() const;
181181
virtual void updateBaseClasses(const BaseClassList &bcd);
182-
virtual BaseClassList subClasses() const;
182+
virtual const BaseClassList &subClasses() const;
183183
virtual void updateSubClasses(const BaseClassList &bcd);
184184
virtual const MemberNameInfoLinkedMap &memberNameInfoLinkedMap() const;
185185
virtual Protection protection() const;
@@ -408,9 +408,9 @@ class ClassDefAliasImpl : public DefinitionAliasMixin<ClassDef>
408408
{ return getCdAlias()->compoundType(); }
409409
virtual QCString compoundTypeString() const
410410
{ return getCdAlias()->compoundTypeString(); }
411-
virtual BaseClassList baseClasses() const
411+
virtual const BaseClassList &baseClasses() const
412412
{ return getCdAlias()->baseClasses(); }
413-
virtual BaseClassList subClasses() const
413+
virtual const BaseClassList &subClasses() const
414414
{ return getCdAlias()->subClasses(); }
415415
virtual const MemberNameInfoLinkedMap &memberNameInfoLinkedMap() const
416416
{ return getCdAlias()->memberNameInfoLinkedMap(); }
@@ -4495,7 +4495,7 @@ ClassDefImpl::CompoundType ClassDefImpl::compoundType() const
44954495
return m_impl->compType;
44964496
}
44974497

4498-
BaseClassList ClassDefImpl::baseClasses() const
4498+
const BaseClassList &ClassDefImpl::baseClasses() const
44994499
{
45004500
return m_impl->inherits;
45014501
}
@@ -4505,7 +4505,7 @@ void ClassDefImpl::updateBaseClasses(const BaseClassList &bcd)
45054505
m_impl->inherits = bcd;
45064506
}
45074507

4508-
BaseClassList ClassDefImpl::subClasses() const
4508+
const BaseClassList &ClassDefImpl::subClasses() const
45094509
{
45104510
return m_impl->inheritedBy;
45114511
}

src/classdef.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,14 +167,14 @@ class ClassDef : public Definition
167167
/** Returns the list of base classes from which this class directly
168168
* inherits.
169169
*/
170-
virtual BaseClassList baseClasses() const = 0;
170+
virtual const BaseClassList &baseClasses() const = 0;
171171

172172
/** Update the list of base classes to the one passed */
173173
virtual void updateBaseClasses(const BaseClassList &bcd) = 0;
174174

175175
/** Returns the list of sub classes that directly derive from this class
176176
*/
177-
virtual BaseClassList subClasses() const = 0;
177+
virtual const BaseClassList &subClasses() const = 0;
178178

179179
/** Update the list of sub classes to the one passed */
180180
virtual void updateSubClasses(const BaseClassList &bcd) = 0;

0 commit comments

Comments
 (0)