issue #10989 bison: error: '%name-prefix' and '%define api.prefix' cannot be used together

- remove the deprecated `-p` option of bison
- updating the minumum version of flex
- removing old test for flex against version >= 2.5.33

Author: albert-github

CMakeLists.txt

@@ -189,8 +189,8 @@ endif ()
 find_program(DOT NAMES dot)
 find_package(Python REQUIRED)
 find_package(FLEX REQUIRED)
-if (FLEX_VERSION VERSION_LESS 2.5.37)
-  message(SEND_ERROR "Doxygen requires at least flex version 2.5.37 (installed: ${FLEX_VERSION})")
+if (FLEX_VERSION VERSION_LESS 2.6.3)
+  message(SEND_ERROR "Doxygen requires at least flex version 2.6.3 (installed: ${FLEX_VERSION})")
 endif()
 find_package(BISON REQUIRED)
 if (BISON_VERSION VERSION_LESS 2.7)

src/CMakeLists.txt

@@ -72,7 +72,7 @@ set_source_files_properties(${GENERATED_SRC}/configoptions.cpp PROPERTIES GENERA
 
 # ce_parse.h
 add_custom_command(
-    COMMAND ${BISON_EXECUTABLE} -l -d -p ce_parsexpYY ${CMAKE_CURRENT_LIST_DIR}/constexp.y -o ce_parse.c
+    COMMAND ${BISON_EXECUTABLE} -l -d ${CMAKE_CURRENT_LIST_DIR}/constexp.y -o ce_parse.c
     DEPENDS ${CMAKE_CURRENT_LIST_DIR}/constexp.y
     OUTPUT ${GENERATED_SRC}/ce_parse.h
     WORKING_DIRECTORY ${GENERATED_SRC}

src/commentscan.l

@@ -943,15 +943,7 @@ STopt  [^\n@\\]*
                                               // of this command.
                                               yyextra->parseMore=TRUE;
 
-                                              // yuk, this is probably not very portable across lex implementations,
-                                              // but we need to know the position in the input buffer where this
-                                              // rule matched.
-                                              // for flex 2.5.33+ we should use YY_CURRENT_BUFFER_LVALUE
-#if YY_FLEX_MAJOR_VERSION>=2 && (YY_FLEX_MINOR_VERSION>5 || (YY_FLEX_MINOR_VERSION==5 && YY_FLEX_SUBMINOR_VERSION>=33))
                                               yyextra->inputPosition=yyextra->prevPosition + (int)(yy_bp - YY_CURRENT_BUFFER_LVALUE->yy_ch_buf);
-#else
-                                              yyextra->inputPosition=yyextra->prevPosition + (int)(yy_bp - yy_current_buffer->yy_ch_buf);
-#endif
                                               yyterminate();
                                             }
                                             else if (it->second.handler==nullptr)
@@ -1021,11 +1013,7 @@ STopt  [^\n@\\]*
                                           yyextra->docGroup.clearHeader();
                                           yyextra->parseMore=TRUE;
                                           yyextra->needNewEntry = TRUE;
-#if YY_FLEX_MAJOR_VERSION>=2 && (YY_FLEX_MINOR_VERSION>5 || (YY_FLEX_MINOR_VERSION==5 && YY_FLEX_SUBMINOR_VERSION>=33))
                                           yyextra->inputPosition=yyextra->prevPosition + (int)(yy_bp - YY_CURRENT_BUFFER_LVALUE->yy_ch_buf) + (int)strlen(yytext);
-#else
-                                          yyextra->inputPosition=yyextra->prevPosition + (int)(yy_bp - yy_current_buffer->yy_ch_buf) + (int)strlen(yytext);
-#endif
                                           yyterminate();
                                         }
 <Comment>{B}*{CMD}[$@\\&~<>#%]          { // escaped character