Skip to content

Commit 6916b03

Browse files
committed
Optimize: usedDir can not be parent of dd if they have the same parent.
1 parent f80b038 commit 6916b03

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/dotdirdeps.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ void writeDotDirDepGraph(FTextStream &t,const DirDef *dd,bool linkRelations)
8181
// draw all directories which have `dd->parent()` as parent and `dd` as dependent
8282
const auto newEnd = std::remove_if(usedDirsNotDrawn.begin(), usedDirsNotDrawn.end(), [&](const DirDef *const usedDir)
8383
{
84-
if (dd!=usedDir && dd->parent()==usedDir->parent() && !usedDir->isParentOf(dd))
84+
if (dd!=usedDir && dd->parent()==usedDir->parent())
8585
{
8686
drawDirectory(t, usedDir, usedDir->isCluster() && !Config_getBool(DOT_TRANSPARENT), dirsInGraph);
8787
return true;
@@ -136,8 +136,7 @@ void writeDotDirDepGraph(FTextStream &t,const DirDef *dd,bool linkRelations)
136136
// shortName().data(),
137137
// !usedDir->isParentOf(this)
138138
// );
139-
if (dir!=usedDir && dir->parent()==usedDir->parent() &&
140-
!usedDir->isParentOf(dd))
139+
if (dir!=usedDir && dir->parent()==usedDir->parent())
141140
// include if both have the same parent (or no parent)
142141
{
143142
drawDirectory(t, usedDir, usedDir->isCluster() && !Config_getBool(DOT_TRANSPARENT), dirsInGraph);

0 commit comments

Comments
 (0)