Skip to content

Commit 76df6de

Browse files
Fix build with MinGW and Ninja
I don't think there should be a check on the generator but on the compiler, because my gcc complains rightfully: c++.exe: warning: /bigobj: linker input file unused because linking not done c++.exe: error: /bigobj: linker input file not found: No such file or directory And this in turn failed the configuration: -- Performing Test ICONV_COMPILES - Failed
1 parent c5d4b67 commit 76df6de

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,7 @@ if (CMAKE_SYSTEM MATCHES "Darwin")
8181
endif()
8282

8383
if (WIN32)
84-
if ((NOT CMAKE_GENERATOR MATCHES "MinGW Makefiles") AND
85-
(NOT CMAKE_GENERATOR MATCHES "MSYS Makefiles") AND
86-
(NOT CMAKE_GENERATOR MATCHES "Unix Makefiles"))
84+
if (MSVC)
8785
if (NOT ICONV_DIR)
8886
set(ICONV_DIR "${PROJECT_SOURCE_DIR}/winbuild")
8987
endif()

0 commit comments

Comments
 (0)