Skip to content

Commit 77167c1

Browse files
committed
Missing filename for tag warnings
With warnings regarding tag files it can happen that the tag filename is not set resulting in a filename `<unknown>` like: ``` <unknown>:370: warning: no uniquely matching class member found for typedef std::array< FT, 3 > CGAL::Surface_mesh_shortest_path_traits< class K, class TriangleMesh >::Barycentric_coordinates Possible candidates: 'Traits::Barycentric_coordinates CGAL::Surface_mesh_shortest_path< class Traits, class VIM, class HIM, class FIM, class VPM >::Barycentric_coordinates' at line 94 of file .../doc_master/doc_tags/Surface_mesh_shortest_path.tag 'unspecified_type SurfaceMeshShortestPathTraits::Barycentric_coordinates' at line 437 of file...doc_tags/Surface_mesh_shortest_path.tag ``` where `<unknown>` should have been `.../doc_tags/Surface_mesh_shortest_path.tag`. This has been corrected by setting the `fileName` (note that the startLine was already set correctly).
1 parent 14fc65f commit 77167c1

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

src/tagreader.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1533,6 +1533,7 @@ void TagFileParser::buildLists(const std::shared_ptr<Entry> &root)
15331533
ce->tagInfoData.anchor = tci->anchor;
15341534
ce->tagInfoData.fileName = tci->filename;
15351535
ce->startLine = tci->lineNr;
1536+
ce->fileName = m_tagName;
15361537
ce->hasTagInfo = TRUE;
15371538
ce->id = tci->clangId;
15381539
ce->lang = tci->isObjC ? SrcLangExt::ObjC : SrcLangExt::Unknown;
@@ -1604,6 +1605,7 @@ void TagFileParser::buildLists(const std::shared_ptr<Entry> &root)
16041605
ce->tagInfoData.tagName = m_tagName;
16051606
ce->tagInfoData.fileName = tci->filename;
16061607
ce->startLine = tci->lineNr;
1608+
ce->fileName = m_tagName;
16071609
ce->hasTagInfo = TRUE;
16081610
ce->id = tci->clangId;
16091611

@@ -1660,6 +1662,7 @@ void TagFileParser::buildLists(const std::shared_ptr<Entry> &root)
16601662
ne->tagInfoData.tagName = m_tagName;
16611663
ne->tagInfoData.fileName = tni->filename;
16621664
ne->startLine = tni->lineNr;
1665+
ne->fileName = m_tagName;
16631666
ne->hasTagInfo = TRUE;
16641667
ne->id = tni->clangId;
16651668

@@ -1681,6 +1684,7 @@ void TagFileParser::buildLists(const std::shared_ptr<Entry> &root)
16811684
pe->tagInfoData.tagName = m_tagName;
16821685
pe->tagInfoData.fileName = tpgi->filename;
16831686
pe->startLine = tpgi->lineNr;
1687+
pe->fileName = m_tagName;
16841688
pe->hasTagInfo = TRUE;
16851689

16861690
buildMemberList(pe,tpgi->members);
@@ -1702,6 +1706,7 @@ void TagFileParser::buildLists(const std::shared_ptr<Entry> &root)
17021706
ge->tagInfoData.tagName = m_tagName;
17031707
ge->tagInfoData.fileName = tgi->filename;
17041708
ge->startLine = tgi->lineNr;
1709+
ge->fileName = m_tagName;
17051710
ge->hasTagInfo = TRUE;
17061711

17071712
buildMemberList(ge,tgi->members);
@@ -1749,6 +1754,7 @@ void TagFileParser::buildLists(const std::shared_ptr<Entry> &root)
17491754
pe->tagInfoData.tagName = m_tagName;
17501755
pe->tagInfoData.fileName = stripExtension(tpi->filename);
17511756
pe->startLine = tpi->lineNr;
1757+
pe->fileName = m_tagName;
17521758
pe->hasTagInfo = TRUE;
17531759
root->moveToSubEntryAndKeep(pe);
17541760
}

0 commit comments

Comments
 (0)