Problem with refitem command (tests 45)

When running a link checker over the (x)html results of the doxygen tests 45 we get the error:
```
===============================

Processing      file:///.../ex_1/html/index.xhtml

List of broken links and other issues:
file:///.../ex_1/html/item2.xhtml
  Line: 71
  Code: 200 (no message)
 To do: Some of the links to this resource point to broken URI fragments
        (such as index.html#fragment).
The following fragments need to be fixed:
        item2                           Line: 71

```

This accounts also for the second example (just with subdirs enabled).

When we change *.dox files so that the `\mainpage` is disabled and `\page` is enabled the result for the subdir version is so that the links don't work at all as it searches for e.g. `.../html/d5/d4a/d5/d4a/pg1.xhtml#item1` instead of `html/d5/d4a/pg1.xhtml#item1`.

(I slightly modified the example as to compare the links with the links for the `\ref` command).

Author: albert-github

src/docparser.cpp

@@ -2274,14 +2274,40 @@ void DocSecRefItem::parse()
   doctokenizerYYsetStatePara();
   handlePendingStyleCommands(this,m_children);
 
-  const SectionInfo *sec=0;
   if (!m_target.isEmpty())
   {
-    sec = SectionManager::instance().find(m_target);
-    if (sec)
+    SrcLangExt lang = getLanguageFromFileName(m_target);
+    m_relPath = g_relPath;
+    const SectionInfo *sec = SectionManager::instance().find(m_target);
+    if (sec==0 && lang==SrcLangExt_Markdown) // lookup as markdown file
     {
-      m_file   = sec->fileName();
-      m_anchor = sec->label();
+      sec = SectionManager::instance().find(markdownFileNameToId(m_target));
+    }
+    if (sec) // ref to section or anchor
+    {
+      PageDef *pd = 0;
+      if (sec->type()==SectionType::Page)
+      {
+        pd = Doxygen::pageLinkedMap->find(m_target);
+      }
+      m_ref          = sec->ref();
+      m_file         = stripKnownExtensions(sec->fileName());
+      if (sec->type()==SectionType::Anchor)
+      {
+        m_refType = Anchor;
+      }
+        else if (sec->type()==SectionType::Table)
+      {
+        m_refType = Table;
+      }
+      else
+      {
+        m_refType = Section;
+      }
+      m_isSubPage    = pd && pd->hasParentPage();
+      if (sec->type()!=SectionType::Page || m_isSubPage) m_anchor = sec->label();
+      //printf("m_ref=%s,m_file=%s,type=%d\n",
+      //    qPrint(m_ref),qPrint(m_file),m_refType);
     }
     else
     {

src/docparser.h

@@ -163,6 +163,7 @@ class DocNode
     /*! Sets whether or not this item is inside a preformatted section */
     void setInsidePreformatted(bool p) { m_insidePre = p; }
     DocNode *m_parent = 0;
+    enum RefType { Unknown, Anchor, Section, Table };
   private:
 
     bool m_insidePre = false;
@@ -883,7 +884,6 @@ class DocRef : public CompAccept<DocRef>
     bool isSubPage() const       { return m_isSubPage; }
 
   private:
-    enum RefType { Unknown, Anchor, Section, Table };
     RefType    m_refType = Unknown;
     bool       m_isSubPage = false;
     QCString   m_file;
@@ -1005,12 +1005,20 @@ class DocSecRefItem : public CompAccept<DocSecRefItem>
     QCString target() const     { return m_target; }
     QCString file() const       { return m_file; }
     QCString anchor() const     { return m_anchor; }
+    QCString relPath() const      { return m_relPath; }
+    QCString ref() const          { return m_ref; }
+    bool refToTable() const      { return m_refType==Table; }
+    bool isSubPage() const       { return m_isSubPage; }
     void parse();
 
   private:
     QCString  m_target;
-    QCString  m_file;
-    QCString  m_anchor;
+    RefType    m_refType = Unknown;
+    bool       m_isSubPage = false;
+    QCString   m_file;
+    QCString   m_relPath;
+    QCString   m_ref;
+    QCString   m_anchor;
 };
 
 /** Node representing a list of section references */

src/htmldocvisitor.cpp

@@ -1887,15 +1887,24 @@ void HtmlDocVisitor::visitPost(DocRef *ref)
 void HtmlDocVisitor::visitPre(DocSecRefItem *ref)
 {
   if (m_hide) return;
-  QCString refName=addHtmlExtensionIfMissing(ref->file());
-  m_t << "<li><a href=\"" << refName << "#" << ref->anchor() << "\">";
-
+  //QCString refName=addHtmlExtensionIfMissing(ref->file());
+  //m_t << "<li><a href=\"" << refName << "#" << ref->anchor() << "\">";
+  if (!ref->file().isEmpty())
+  {
+    m_t << "<li>";
+    startLink(ref->ref(),ref->file(),ref->relPath(),ref->isSubPage() ? QCString() : ref->anchor());
+  }
 }
 
-void HtmlDocVisitor::visitPost(DocSecRefItem *)
+void HtmlDocVisitor::visitPost(DocSecRefItem *ref)
 {
   if (m_hide) return;
-  m_t << "</a></li>\n";
+  if (!ref->file().isEmpty())
+  {
+    endLink();
+    m_t << "</li>\n";
+  }
+  // m_t << "</a></li>\n";
 }
 
 void HtmlDocVisitor::visitPre(DocSecRefList *s)

src/latexdocvisitor.cpp

@@ -1539,22 +1539,47 @@ void LatexDocVisitor::visitPre(DocSecRefItem *ref)
 {
   if (m_hide) return;
   m_t << "\\item \\contentsline{section}{";
+  if (ref->isSubPage())
+  {
+    startLink(ref->ref(),QCString(),ref->anchor());
+  }
+  else
+  {
+    if (!ref->file().isEmpty()) startLink(ref->ref(),ref->file(),ref->anchor(),ref->refToTable());
+  }
+  #if 0
   static bool pdfHyperlinks = Config_getBool(PDF_HYPERLINKS);
   if (pdfHyperlinks)
   {
     m_t << "\\mbox{\\hyperlink{" << ref->file() << "_" << ref->anchor() << "}{" ;
   }
+  #endif
 }
 
 void LatexDocVisitor::visitPost(DocSecRefItem *ref)
 {
   if (m_hide) return;
+  #if 0
   static bool pdfHyperlinks = Config_getBool(PDF_HYPERLINKS);
   if (pdfHyperlinks)
   {
     m_t << "}}";
   }
   m_t << "}{\\ref{" << ref->file() << "_" << ref->anchor() << "}}{}\n";
+  #endif
+  if (ref->isSubPage())
+  {
+    endLink(ref->ref(),QCString(),ref->anchor());
+  }
+  else
+  {
+    if (!ref->file().isEmpty()) endLink(ref->ref(),ref->file(),ref->anchor(),ref->refToTable());
+  }
+  m_t << "}{\\ref{";
+  if (!ref->file().isEmpty()) m_t << stripPath(ref->file());
+  if (!ref->file().isEmpty() && !ref->anchor().isEmpty()) m_t << "_";
+  if (!ref->anchor().isEmpty()) m_t << ref->anchor();
+  m_t << "}}{}\n";
 }
 
 void LatexDocVisitor::visitPre(DocSecRefList *)

src/xmldocvisitor.cpp

@@ -1022,7 +1022,10 @@ void XmlDocVisitor::visitPost(DocRef *ref)
 void XmlDocVisitor::visitPre(DocSecRefItem *ref)
 {
   if (m_hide) return;
-  m_t << "<tocitem id=\"" << ref->file() << "_1" << ref->anchor() << "\">";
+  m_t << "<tocitem id=\"" << ref->file();
+  if (!ref->anchor().isEmpty()) m_t << "_1" << ref->anchor();
+  m_t << "\"";
+  m_t << ">";
 }
 
 void XmlDocVisitor::visitPost(DocSecRefItem *)

testing/045/indexpage.xml

@@ -9,7 +9,7 @@
       <para>
         <toclist>
           <tocitem id="index_1item1">First Item</tocitem>
-          <tocitem id="item2_1item2">Second Item</tocitem>
+          <tocitem id="item2">Second Item</tocitem>
           <tocitem id="item2_1item3">Third Item</tocitem>
         </toclist>
       </para>