New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Don't add trailing spaces when generating a Doxyfile (Origin: bugzilla #583213) #3396

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity trivial in component general for ---
Reported in version unspecified on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

On 2009-05-19 13:47:52 +0000, Alejandro wrote:

Trailing spaces tend to be problematic because they "pollute" diffs and are commonly seen as a "bad practice". There even are some SCM hooks that check for trailing spaces and reject changesets if they have any.

doxygen -g and doxygen -u both creates a Doxyfile with trailing spaces, which can be really annoying in that scenarios.

Attached is a patch to avoid adding trailing spaces when doxygen generates a Doxyfile.

On 2009-05-19 13:49:26 +0000, Alejandro wrote:

Created attachment 134937
Don't add trailing spaces when generating a Doxyfile (against svn trunk r692)

On 2009-05-19 14:18:17 +0000, Leandro Lucarella wrote:

The patch should be applied with patch -p1 BTW (I made the patch, not Alejandro, I've used a "bugmenot" account to fill the bug report and then remembered I had my own account in this bugzilla =).

On 2009-05-19 17:33:30 +0000, Leandro Lucarella wrote:

Created attachment 134959
Fixed patch (against svn trunk r692)

Here is a new version of the patch that fixes a double space that was introduced for list options.

On 2009-08-14 08:23:14 +0000, Dimitri van Heesch wrote:

Thanks for the patch. I'll include it in the next subversion update.

On 2009-08-20 10:12:45 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.6.0. Please verify if this is indeed the case and reopen the
bug if you think it is not fixed (include any additional information that you
think can be relevant).

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment