New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code.cpp generates extra </span> tags (Origin: bugzilla #599224) #3565

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity minor in component general for ---
Reported in version 1.6.1 on platform Other
Assigned to: Dimitri van Heesch

On 2009-10-21 18:14:14 +0000, Mike Sieweke wrote:

The HTML generated for C code has the occasional extra tag. Some HTML parsers (including the one in swish-e) declare errors on the extra tags.

The problem is in endCodeLine() in code.cpp (although the same problem exists in code.l, fortrancode.cpp, fortrancode.l, latexgen.cpp, etc.). This is the original function. It writes a closing tag, but doesn't set g_currentFontClass to 0. That lets a later point in the code send an extra closing tag.

#line 8852
static void endCodeLine()
{
if (g_currentFontClass) { g_code->endFontClass(); }
g_code->endCodeLine();
}

The fix is obvious:

static void endCodeLine()
{
if (g_currentFontClass)
{
g_code->endFontClass();
g_currentFontClass=0;
}
g_code->endCodeLine();
}

On 2009-10-25 11:43:03 +0000, Dimitri van Heesch wrote:

Indeed. I'll fix this in the next subversion update.

On 2009-12-30 13:38:58 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.6.2. Please verify if this is indeed the case and reopen the
bug if you think it is not fixed (include any additional information that you
think can be relevant).

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment