Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QHP_SECT_FILTER_ATTRS is not split correctly (Origin: bugzilla #640588) #4110

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Copy link
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity normal in component general for ---
Reported in version 1.7.3 on platform Other
Assigned to: Dimitri van Heesch

On 2011-01-25 21:53:43 +0000, Haffmans wrote:

The configuration string QHP_SECT_FILTER_ATTRS is not split on spaces correctly, which results in filter attributes of the QHP file like "attr1 attr2", instead of two attributes "attr1" and "attr2".

This seems to be a compiler or Qt bug, as the issue is resolved by changing line 88 from:

QStringList customFilterAttributes = QStringList::split(' ', Config_getString("QHP_CUST_FILTER_ATTRS"));

to:

QStringList customFilterAttributes = QStringList::split(QChar(' '), Config_getString("QHP_CUST_FILTER_ATTRS"));

And making a similar change on line 99.

I assume this means the wrong version of QStringList::split() is picked. If I replace the QChar with QRegExp or QCString it breaks, so it looks like this hint is necessary - at least it is in my case. Perhaps there are other locations in the source code where the same change is required?

This is on Arch x64, for this test I downloaded and used the source from the Doxygen website. The bug doesn't seem to occur in the (1.6.3) OpenSuse packaged builds.

On 2011-01-25 21:54:44 +0000, Haffmans wrote:

Forgot to mention the source file name this occurs in: src/qhp.cpp (lines 88 and 99)

On 2011-01-25 22:38:24 +0000, Dimitri van Heesch wrote:

Thanks. I'll include the changes in the next subversion update.

On 2011-03-28 14:19:30 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.7.4. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.