New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect definition of compatibility AvailabilityMacros (MAC_OS_X_VERSION_10_X) (Origin: bugzilla #673219) #4651

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity normal in component build for ---
Reported in version 1.8.0 on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

On 2012-03-31 02:56:14 +0000, Ryan Schmidt wrote:

qtools/qglobal.h includes <AvailabilityMacros.h> and then adds defines for any newer versions of OS X. But the defines are defined incorrectly. AvailabilityMacros.h on my OS X 10.6 system shows the defines being defined as follows -- each version increases by ten:

#define MAC_OS_X_VERSION_10_0 1000
#define MAC_OS_X_VERSION_10_1 1010
#define MAC_OS_X_VERSION_10_2 1020
#define MAC_OS_X_VERSION_10_3 1030
#define MAC_OS_X_VERSION_10_4 1040
#define MAC_OS_X_VERSION_10_5 1050
#define MAC_OS_X_VERSION_10_6 1060

But qglobal.h defines them like this -- with each version increasing by one:

if !defined(MAC_OS_X_VERSION_10_3)

define MAC_OS_X_VERSION_10_3 MAC_OS_X_VERSION_10_2 + 1

endif

if !defined(MAC_OS_X_VERSION_10_4)

define MAC_OS_X_VERSION_10_4 MAC_OS_X_VERSION_10_3 + 1

endif

if !defined(MAC_OS_X_VERSION_10_5)

define MAC_OS_X_VERSION_10_5 MAC_OS_X_VERSION_10_4 + 1

endif

if !defined(MAC_OS_X_VERSION_10_6)

define MAC_OS_X_VERSION_10_6 MAC_OS_X_VERSION_10_5 + 1

endif

if !defined(MAC_OS_X_VERSION_10_7)

define MAC_OS_X_VERSION_10_7 MAC_OS_X_VERSION_10_6 + 1

endif

The attached patch fixes this.

On 2012-03-31 02:56:58 +0000, Ryan Schmidt wrote:

Created attachment 211014
proposed patch

On 2012-03-31 02:57:38 +0000, Ryan Schmidt wrote:

Created attachment 211015
proposed patch

On 2012-04-04 18:20:32 +0000, Dimitri van Heesch wrote:

Hi Ryan,

I doubt that this will make a functional difference, but I agree it is better to use the same versioning scheme as Apple does.

On 2012-05-19 12:26:37 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.1. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment