New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmatched quote in inline comment breaking aliases (Origin: bugzilla #674842) #4682

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity normal in component general for ---
Reported in version 1.8.0 on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

On 2012-04-26 04:22:53 +0000, Travis wrote:

This is probably going to sound weird (and after the four hours of hunting it took to figure out what in the hell was going on), I believe I've identified a bug with an unmatched quote in an inline comment breaking user-defined alias recognition. Normal doxygen commands continue to function as expected, but after the line of the unmatched quotation mark, all defined aliases stopped functioning. I tested only this change to confirm.

But first, some caveats; we're an LDMud coded in LPC, and we're running doxygen with our .c files aliased to java, as it's helped resolve some issues we've had with differences between C and LPC. The inline comment is reproduced below:

/* exit messages used to be printed here;
Now, they're printed by the "exit_room_message function
which is called in /obj/living/movement.c

  Done to resolve issues with exit messages printing, then
  player movement being stopped by a hook.
  Misery, November 2011*/

I can provide more information as needed, but hopefully this will be enough to reproduce the error as we've been able to reliably reproduce it in additional files. For reference:

Our only defined aliases are:
ALIASES = "usage{1}=@Par Usage:\n@code\n\1@endcode"
"synopsis{1}=@Par Synopsis:\n@code\n\1@endcode"

and a typical usage example is:

@Usage{
add_door(ROOM+"door1.c", ROOM+"door2.c");
add_door(ROOM+"door2.c", ROOM+"door1.c");
}

On 2012-05-05 09:23:45 +0000, Dimitri van Heesch wrote:

Can you please attach a self-contained example (source+config file in a tar or zip) that allows me to reproduce the problem? that will make it so much easier for me to analyse the problem.

On 2012-05-05 15:10:18 +0000, Travis wrote:

Created attachment 213494
source + input filter + config

On 2012-06-18 16:15:22 +0000, Akhil Laddha wrote:

Information provided.

On 2012-06-27 19:35:15 +0000, Dimitri van Heesch wrote:

Confirmed. Should be fixed in the next subversion update.

On 2012-07-12 15:41:49 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.1.2. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment