New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error generating svg graphs in case of a double dash in brief description (Origin: bugzilla #678180) #4754

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Owner

doxygen commented Jul 2, 2018

status VERIFIED severity normal in component general for ---
Reported in version 1.8.1.1-SVN on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

On 2012-06-15 17:51:10 +0000, albert wrote:

Created attachment 216534
Example: Error generating svg graphs in case of a double dash in brief description

In case there is a double dash in the brief description of a routine a (caller / callee) svg graph is generated with in the text – when displaying this in Firefox an error message is generated like:

XML Parsing Error: undefined entity
Location: file:///D:/doxygen_bugs/bug_svg/html/aa_8f90_aa86c5ee9dff5b110f4ba85c9ef20f876_icgraph.svg
Line Number 19, Column 1:

When displaying the same file in Internet Explorer this error does not occur.

When looking at the XML recommendation (Extensible Markup Language (XML) 1.0 (Fifth Edition), http://www.w3.org/TR/xml/ ) and specifically at paragraph 4.6 (Predefined Entities, http://www.w3.org/TR/xml/#sec-predefined-ent) we see that there are only 5 predefined entities: &, <, >, ', "

The – "enters" the code in commentscan.l at line 1121 and I think that before the generation of the svg graph this has to be reverted (in the input file for the dot processor in case of the svg output format).

See attachment for an example.

On 2012-06-16 22:01:32 +0000, Dimitri van Heesch wrote:

Indeed.

Inside util.cpp function parseCommentAsText(), the line with

QCString result = s.data();

should become

QCString result = convertCharEntitiesToUTF8(s.data());

Regards,
Dimitri

On 2012-07-12 15:41:54 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.1.2. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.

On 2012-07-22 11:19:29 +0000, albert wrote:

Works as described, graphs are shown properly now

@doxygen doxygen closed this Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment