New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protected statement in Fortran (Origin: bugzilla #695277) #5116

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity normal in component general for ---
Reported in version 1.8.3.1 on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

On 2013-03-06 10:51:20 +0000, dummfikk@gmx.de wrote:

The protected statement in Fortran allows to set global (public) variables to be write protected.

In the following case

-----------------begin numerics.f90
integer(pInt), dimension(2) , protected, public :: &
numerics_integrator = 1_pInt !< method used for state integration
-----------------end numerics.f90

Doxygen classifies "numerics_integrator" as private and finds additional the entities "public" and "protected"

-----------------begin documentation
integer(pint), dimension(2) numerics::numerics_integrator = 1_pInt
integer(pint), dimension(2) numerics::protected
integer(pint), dimension(2) numerics::public
-----------------begin documentation

In the case of only "public" or "private" statements, I don't see any problems.

For further examples, explanation, etc. don't hesitate t contact me

On 2013-03-06 17:50:02 +0000, albert wrote:

I think in the FORTRAN scanner there is a misinterpretation of the usage of public, private and protected, they exclude each other. I see in the standard that public and private exclude each other and that protected can be used independently of this (I'll have a look this).

In the mean time when running the above "example" I don't get the above mentioned problem, I get that numerics_integrator is only public. So please attach an example to this bug report signaling this problem problem, but I think this problem will disappear as well with the future bug fix.

On 2013-03-06 18:17:30 +0000, albert wrote:

Created attachment 238220
PATCH: protected and publuic/private are not on the same level

The keyword protected is independent of public/private, in the past these 3 keywords were mutual exclusive, now protected is possible with public/private

On 2013-03-07 16:47:50 +0000, dummfikk@gmx.de wrote:

I checked it again, it was not working in 1.8.3 but seems to be ok in 1.8.3.1

On 2013-03-07 17:57:05 +0000, albert wrote:

In version 1.8.3.1 I saw that when public or private was used together with protected that in that case only one attribute was given. So I think the separate lines in the documentation might have gone, but the underlying problem was still present so the PATCH is still valid.

On 2013-03-07 21:17:12 +0000, dummfikk@gmx.de wrote:

cool, at least this report was any help to you and not just spam by me.

thanks for the fast response, I really appreciate your work.

On 2013-03-31 13:16:32 +0000, Dimitri van Heesch wrote:

Thanks, I'll include the patch in the next subversion update.

On 2013-05-19 12:36:30 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.4. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment