Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML escaping incorrectly applied in source tooltips (Origin: bugzilla #719389) #5361

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Copy link
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity major in component general for ---
Reported in version 1.8.5 on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

On 2013-11-27 03:05:56 +0000, Jason Erb wrote:

HTML entities in source browser tooltips get HTML escaped, resulting in tooltips containing HTML entities such as " and > instead of double quote and greater than, respectively.

On 2013-12-01 19:24:13 +0000, albert wrote:

Can you please attach a self-contained example (source+config file in a tar or
zip) that allows reproducing the problem?

On 2013-12-15 17:25:28 +0000, Jason Erb wrote:

Here's a page that you can visit that demonstrates the behaviour:

http://sparist.github.io/Om/front__pull__term__operation_8hpp_source.html

To reproduce, hover the class name FrontPullTermOperation in the source code. In the popup, you will see "The <-[terms] operation implementation.", which is taken from the brief comment for FrontPullTermOperation.

Source file for FrontPullTermOperation: https://github.com/sparist/Om/blob/master/code/om/operation/front_pull_term_operation.hpp

The om__operation__front_pull_term_operation__ reference is defined here:
https://github.com/sparist/Om/blob/master/code/om/operation/front_pull_term_operation.dox

On 2013-12-15 18:01:01 +0000, albert wrote:

Created attachment 264232
Minimal example based on the information provided

Minimal example based on the information provided

On 2013-12-15 18:32:53 +0000, albert wrote:

Looks like the docify function is called twice.
The input for docify is already:
The <-[terms] operation implementation.
after docify call (line 1420 of htmlgen.cpp: docify(desc);) this is:
The &lt;-[terms] operation implementation.

Possible problem / solution around line 1314 of htmlgen.cpp (case '&': m_t << "&"; break;)

I'm not sure if the docify call should be removed or the docify subroutine shouldn't do the second substitution or ...

On 2013-12-23 21:52:16 +0000, Dimitri van Heesch wrote:

Confirmed. Should be fixed in the next GIT update.

On 2013-12-24 18:59:27 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.6. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant (preferrably in the form of a self-contained example).

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.