Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML empty <argsstring/> in python (Origin: bugzilla #752658) #5831

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Copy link
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity normal in component general for ---
Reported in version 1.8.11-GIT on platform Other
Assigned to: Dimitri van Heesch

On 2015-07-21 07:46:59 +0000, erez.oxman@gmail.com wrote:

Hi,

I'm trying to document the python package https://github.com/simplejson/simplejson, and looking on the xml output.

In the majority of functions, it does correctly output the argsstring, but in some cases it does not.

For example:

  1. simplejson.encoder.JSONEncoderForHTML.iterencode:

    def def simplejson.encoder.JSONEncoderForHTML.iterencode iterencode
  2. simplejson.ordered_dict.OrderedDict.fromkeys:

def def simplejson.ordered_dict.OrderedDict.fromkeys fromkeys

I have seen it happening in other packages as well, but unfortunately can't find a logic when exactly this bug appears.

If you need any more info regarding this issue I'll be happy to provide.

Thanks.

On 2015-07-25 15:46:25 +0000, albert wrote:

Problem comes (checked for the 2 situations described) from the fact that the last argument has a default value, and the end of the list is not handled properly.

I've just pushed a proposed patch to github (pull request 371).

On 2015-07-25 17:53:29 +0000, erez.oxman@gmail.com wrote:

Thanks very much for the speedy fix.

I did report this issue a while ago as a follow up in ticket # 739056:
https://bugzilla.gnome.org/show_bug.cgi?id=739056#c4
Status Reopened.

If you have a working setup, please check if this fixes # 739056, and close it as well.

Thx again, I'll keep an eye open for more cases if I encounter them in the future.

On 2015-07-25 20:49:20 +0000, erez.oxman@gmail.com wrote:

In my setup, the latest git with changes you suggested to src/pyscanner.l , somehow the problems (1),(2) remain.

I'm not very fluent in git/github, so it might be the cause for that. When the pull request is merged, I'll retry.

On 2015-07-26 08:26:30 +0000, albert wrote:

(In reply to erez.oxman from comment # 2)

Thanks very much for the speedy fix.

I did report this issue a while ago as a follow up in ticket # 739056:
https://bugzilla.gnome.org/show_bug.cgi?id=739056#c4
Status Reopened.

If you have a working setup, please check if this fixes # 739056, and close
it as well.

Thx again, I'll keep an eye open for more cases if I encounter them in the
future.

Bug 739056 - Python xml - argsstring is empty, while HTML have arguments indeed looks to me that it is the same problem.

On 2015-07-26 08:28:41 +0000, albert wrote:

(In reply to erez.oxman from comment # 3)

In my setup, the latest git with changes you suggested to src/pyscanner.l ,
somehow the problems (1),(2) remain.

I'm not very fluent in git/github, so it might be the cause for that. When
the pull request is merged, I'll retry.

Strange that this does not work for you. Please test again and put a print statement into the pyscanner.l so you are sure that you use the right version.

On 2015-07-26 10:06:33 +0000, Dimitri van Heesch wrote:

I've merged the pull request 371. Let me know if it correctly solves the issue.

On 2015-07-26 11:11:57 +0000, erez.oxman@gmail.com wrote:

Everything works great now, bug solved. Thanks again for all the help.

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.