-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make email obfuscation optional #8989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@AMDmi3 Can you motivate why you do not want obfuscation? The idea behind it is to avoid that web scrapers can easily collect the mail addresses and start sending spam. |
albert-github
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally when you would click on the link the default mailer would open with the right address.
What is the reason that you want to have your email address readable in the documentation?
Wouldn't it be a easier potential way to get spam mail?
0ea9694 to
08cda15
Compare
|
@doxygen @albert-github it should be obvious, I want my email to be readable both as text (without |
src/htmldocvisitor.cpp
Outdated
| const char *p = url.data(); | ||
| uint size=3; | ||
| while (*p) | ||
| if (!Config_getBool(OBFUSCATE_EMAILS)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow doxygen's coding style, i.e. matching braces should be aligned on the same column. I had already fixed this, but your force commit undid my changes, so please do them yourself this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
08cda15 to
fe818b6
Compare
|
Oh, and I've just realized one thing: the link text is in fact intended to be readable. For me it is not though, and that's caused by |
|
Shouldn't this option also have the |
|
Good point, I fixed it: 5da7df8 |
I've noticed that my email is obfuscated in Doxygen output, and that's definitely not that I want. There was no option to disable this behavior and I've added one. The default behavior is unchanged, but specifying
OBFUSCATE_EMAILS = Falsein Doxyfile disables obfuscation.Here's an example case:
Diff for generated
html/index.htmlwithDoxyfile1andDoxyfile2: