Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError parsing Electron Release list #50

Closed
jason-invision opened this issue May 28, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@jason-invision
Copy link
Contributor

commented May 28, 2019

Describe the bug
During a scan of my app I receive a TypeError while the Electron Release List is being parsed.

To Reproduce
Steps to reproduce the behavior:

  1. Run electronegativity -i my-app -o results.csv

Expected behavior
I expected the Release List to be parsed and my app to be scanned.

**Stacktraces **

Releases list is up to date.
(node:54021) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'value' of undefined
    at run (/Users/jasonrogers/.nvm/versions/node/v8.15.1/lib/node_modules/@doyensec/electronegativity/dist/runner.js:211:26)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)
(node:54021) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 7)
(node:54021) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Platform (please complete the following information):

  • OS: Mac
  • Electronegativity version: 1.2.1

Additional context
I noticed that downloading the Release List is taking a long time. Could the download be timing out, and, therefore, only a partial file being downloaded?

@phosphore

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Hey Jason,

Can you try cloning the Github repository? I think this should have been fixed in 84316b1, while the npm repo is still behind this.

Let me know if this fixes it or I'll investigate later in the day,

Cheers!

@jason-invision

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

I cloned the Github repository and followed the build instructions with the same result.

git log --oneline | head -n 1
b32b81b report CSP sample in CSPGlobalCheck issues

@phosphore phosphore closed this in 69a4795 May 29, 2019

@phosphore

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Hey @jason-invision,

Can you try to git pull the repository with the new fix 69a4795 and let me know if that works for you?

Thanks!

@phosphore phosphore reopened this May 29, 2019

@jason-invision

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

I upgraded and am still receiving the same result. Is there something I can debug on my end to help identify the root cause?

phosphore added a commit that referenced this issue May 29, 2019

@phosphore

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Sorry for the delay, 0b682c2 should fix this. Try pulling the repository now and remember to run npm run build.
Let me know if you still experience the bug after this.

As per your suggestion I included a paragraph in our issue template suggesting to include information about the target test application, code snippet, public software or repository Electronegativity is having trouble with and to provide a link.

@jason-invision

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

It appears to be working now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.