Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timestamp 'created' and 'lastUpdate' variables in Firestore functions #743

Merged
merged 10 commits into from Jul 19, 2022

Conversation

magancete
Copy link

@magancete magancete commented Jun 18, 2022

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

The objective of this update is to add a Timestamp variable to the documents, giving the possibility of being able to filter the searches by date of creation or last modification.

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

I have tried to create documents and edit them in Firestore and it works without problems.

Other information

Added 'created' and 'lastUpdate' variable in Timestamp format inside functions 'addDocumentToFirestoreCollection', 'setDocumentInFirestoreCollection' and 'updateDocumentInFirestoreCollection'
Added optional 'timestamp' boolean variable in 'addDocumentToFirestoreCollection', 'setDocumentInFirestoreCollection' and 'updateDocumentInFirestoreCollection'
Added 'created' and 'lastUpdate' variable in Timestamp format inside functions 'addDocumentToFirestoreCollection', 'setDocumentInFirestoreCollection' and 'updateDocumentInFirestoreCollection'
Updated definitions of functions 'addDocumentToFirestoreCollection', 'setDocumentInFirestoreCollection' and 'updateDocumentInFirestoreCollection'
@magancete magancete changed the title Added timestamp created and lastUpdate variables in firestore Added timestamp 'created' and 'lastUpdate' variables in firestore Jun 19, 2022
@magancete magancete changed the title Added timestamp 'created' and 'lastUpdate' variables in firestore Added timestamp 'created' and 'lastUpdate' variables in Firestore Jun 19, 2022
@magancete magancete changed the title Added timestamp 'created' and 'lastUpdate' variables in Firestore Added timestamp 'created' and 'lastUpdate' variables in Firestore functions Jun 19, 2022
@magancete magancete marked this pull request as ready for review June 19, 2022 09:47
@dpa99c dpa99c changed the base branch from master to dev July 19, 2022 13:52
@dpa99c dpa99c merged commit 1cbbee4 into dpa99c:dev Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants