GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Current tests for NWMatcher 1.2.3 shows errors in IE6-IE7 (0 elements found):
selectors jquery-1.5.1 prototype-1.7 mootools-1.3.1 nwmatcher-1.2.3
a[href][lang][class] 25 ms | 1 found 23 ms | 1 found 24 ms | 1 found 12 ms | 0 found
div[class] 6 ms | 51 found 12 ms | 51 found 11 ms | 51 found 5 ms | 0 found
There is issue with ATTR_MAPPING for getAttribute("class") and hasAttribute("class") in IE6-7-8. Debugging NWMatcher 1.2.4 in IE8 debugger shows that node.getAttributeNode("className") === null and node.getAttributeNode("class") returns proper DispHTMLDOMAttribute, and IE6-7 demonstrates the same behavior.
node.getAttributeNode("className") === null
I believe I didn't exactly understood your complete statement.
Could you post a selector test that show the IE 6-7-8 issue you talk about in version 1.2.4 ?
I forgot to tell I fixed the page you linked to with new version of NWMatcher 1.2.4.
you are correct, attribute mapping is necessary only when accessing the element property directly.
It is not necessary when reading element attributes through getAttribute or getAttributeNode (used to emulate hasAttribute).
I will remove them as soon as possible, I am travelling for vacation this weekend and will be out for one month.
I hope to be able to apply the changes before leaving or during the long travel.
Thank you again for the help.
Fix of issue #38 - ATTR_MAPPING removed