New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding whitespace around = in global config options parse (#76) #77

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@raspberrypython

raspberrypython commented Oct 11, 2017

https://www.samba.org/samba/docs/man/manpages-3/smb.conf.5.html

Socket options:

To specify an argument use the syntax SOME_OPTION = VALUE for example SO_SNDBUF = 8192. Note that you must not have any spaces before or after the = sign.

To distinguish option arguments from global options, the global options have spaces surrounding the = but arguments do not.
The options parsing has been altered to take this into account.

@raspberrypython

This comment has been minimized.

Show comment
Hide comment
@raspberrypython

raspberrypython commented Oct 11, 2017

Issue #76

@dperson dperson self-assigned this Oct 12, 2017

@dperson

This comment has been minimized.

Show comment
Hide comment
@dperson

dperson Oct 12, 2017

Owner

I don't think this will actually do what you want. I've fixed the bug in #76 separately.

Owner

dperson commented Oct 12, 2017

I don't think this will actually do what you want. I've fixed the bug in #76 separately.

@dperson dperson closed this Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment