Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: next url on login (OAuth, OID, DB) #1804

Merged
merged 2 commits into from Feb 15, 2022
Merged

fix: next url on login (OAuth, OID, DB) #1804

merged 2 commits into from Feb 15, 2022

Conversation

dpgaspar
Copy link
Owner

Description

Fixes next URL logic for OAuth, OID and DB

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #1804 (2bca590) into master (dd560f8) will increase coverage by 0.05%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1804      +/-   ##
==========================================
+ Coverage   77.06%   77.11%   +0.05%     
==========================================
  Files          56       56              
  Lines        8226     8229       +3     
==========================================
+ Hits         6339     6346       +7     
+ Misses       1887     1883       -4     
Flag Coverage Δ
python 77.11% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/security/views.py 62.56% <73.33%> (+0.06%) ⬆️
flask_appbuilder/utils/base.py 93.33% <100.00%> (+5.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd560f8...2bca590. Read the comment docs.

@dpgaspar dpgaspar merged commit 8a18281 into master Feb 15, 2022
12 checks passed
@dpgaspar dpgaspar deleted the fix/login-next-url branch February 15, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant