Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CRUD MVC log message #2045

Merged
merged 7 commits into from May 19, 2023
Merged

fix: CRUD MVC log message #2045

merged 7 commits into from May 19, 2023

Conversation

dpgaspar
Copy link
Owner

Description

Don't set a database exception details into a log message or back to the user

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2045 (95d7150) into master (98e3808) will increase coverage by 0.10%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
+ Coverage   78.52%   78.62%   +0.10%     
==========================================
  Files          72       72              
  Lines        8698     8698              
==========================================
+ Hits         6830     6839       +9     
+ Misses       1868     1859       -9     
Flag Coverage Δ
python 78.62% <50.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/models/sqla/interface.py 83.07% <28.57%> (+1.15%) ⬆️
flask_appbuilder/babel/manager.py 95.45% <100.00%> (ø)
flask_appbuilder/models/base.py 74.17% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

@dpgaspar dpgaspar merged commit ae25ad4 into master May 19, 2023
11 of 12 checks passed
@dpgaspar dpgaspar deleted the fix/log-message branch May 19, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant