From 17dc4a1c98db11d395409261813fab45a2593d99 Mon Sep 17 00:00:00 2001 From: Johnny Mijnhout Date: Thu, 19 Jul 2018 11:08:05 +0200 Subject: [PATCH 1/2] Do not update a dictionary as a class property, as it will not update the instance, but the class itself --- arctic/mixins.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arctic/mixins.py b/arctic/mixins.py index 75627aa2..85ca774b 100755 --- a/arctic/mixins.py +++ b/arctic/mixins.py @@ -188,7 +188,7 @@ def get_actions(self): # noqa: C901 if action[2].get('style'): allowed_action['custom_style'] = True if action[2].get('form_action'): - action[2]['form_action'] = self.in_modal( + allowed_action['form_action'] = self.in_modal( reverse_url(action[2]['form_action'], obj)) allowed_action.update(action[2]) From 80782dbf863426facb242310a34d2e6bd0c5b229 Mon Sep 17 00:00:00 2001 From: Johnny Mijnhout Date: Thu, 19 Jul 2018 11:11:17 +0200 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 299f4796..d657466d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/). Always reference the ticket number at the end of the issue description. +## Pending + +### Fixed + +- get_actions: formaction dictionary was updated directly as class attribute ## 1.3.1 (2018-07-03)