From e778be0eb3d472bca7101dfe000f11e06dc22614 Mon Sep 17 00:00:00 2001 From: "d.choban" Date: Mon, 28 Jan 2019 16:33:31 +0200 Subject: [PATCH 1/2] #334 Fixed response in DeletionMixin after `delete` method is called --- CHANGELOG.md | 10 +++++++++- arctic/generics.py | 3 +-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 27543418..4863e6f0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/). Always reference the ticket number at the end of the issue description. +## pending + +### Fixed + +- Fixed response in DeletionMixin after `delete` method is called [#334][334] + +[334]: //github.com/sanoma/django-arctic/issues/334 + + ## 1.3.6 (2019-01-22) ### Fixed @@ -30,7 +39,6 @@ Always reference the ticket number at the end of the issue description. [324]: //github.com/sanoma/django-arctic/issues/324 [322]: //github.com/sanoma/django-arctic/issues/322 -## pending: ## 1.3.5 (2018-12-21) diff --git a/arctic/generics.py b/arctic/generics.py index c4745154..b24a3eec 100755 --- a/arctic/generics.py +++ b/arctic/generics.py @@ -873,8 +873,7 @@ def get(self, request, *args, **kwargs): if can_delete and self.redirect: messages.success(request, self.get_success_message(self.object)) - self.delete(request, *args, **kwargs) - return redirect(self.get_success_url()) + return self.delete(request, *args, **kwargs) context = self.get_context_data( object=self.object, From 484cfc77beae4c4d9ceee4de2bd144d9db5f95a1 Mon Sep 17 00:00:00 2001 From: "d.choban" Date: Mon, 28 Jan 2019 18:10:13 +0200 Subject: [PATCH 2/2] #334 Overrided `delete` in DeletionMixin and and made this fix non-breaking --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4863e6f0..3d0e637e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,7 +12,7 @@ Always reference the ticket number at the end of the issue description. ### Fixed -- Fixed response in DeletionMixin after `delete` method is called [#334][334] +- BREAKING! Fixed response in DeletionMixin after `delete` method is called [#334][334] [334]: //github.com/sanoma/django-arctic/issues/334