Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin protocol updates #1948

Open
wants to merge 9 commits into
base: master
from

Conversation

@TylerLubeck
Copy link

TylerLubeck commented Nov 8, 2019

I've been digging in to the admin client and found myself adding extra api version support


This change is Reviewable

('config_names', String('utf-8')),
('config_value', String('utf-8')),
('read_only', Boolean),
('config_source', Int8),

This comment has been minimized.

Copy link
@TylerLubeck

TylerLubeck Nov 8, 2019

Author

It looks like this was renamed from is_default to config_source, and the type changed from Boolean to Int8 in v1 as well, but I didn't include that fix here. Should I?

@TylerLubeck TylerLubeck force-pushed the TylerLubeck:admin-protocol-updates branch from c51d814 to 68d8aad Nov 8, 2019
@TylerLubeck TylerLubeck force-pushed the TylerLubeck:admin-protocol-updates branch from 68d8aad to fa35d52 Nov 8, 2019
@TylerLubeck

This comment has been minimized.

Copy link
Author

TylerLubeck commented Nov 12, 2019

I know how this sounds, but I can't for the life of me reproduce the test failure locally. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.