Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin protocol updates #1948

Open
wants to merge 11 commits into
base: master
from

Add support for DescribeConfigs API v2

  • Loading branch information
TylerLubeck committed Nov 8, 2019
commit fa35d5214a5a107019328be88f427f78221ae168
@@ -802,7 +802,7 @@ def describe_configs(self, config_resources, include_synonyms=False):
DescribeConfigsRequest[version](resources=topic_resources)
))

elif version == 1:
elif version <= 2:
if len(broker_resources) > 0:
for broker_resource in broker_resources:
try:
@@ -708,6 +708,28 @@ class DescribeConfigsResponse_v1(Response):
('config_source', Int8)))))))
)

class DescribeConfigsResponse_v2(Response):
API_KEY = 32
API_VERSION = 2
SCHEMA = Schema(
('throttle_time_ms', Int32),
('resources', Array(
('error_code', Int16),
('error_message', String('utf-8')),
('resource_type', Int8),
('resource_name', String('utf-8')),
('config_entries', Array(
('config_names', String('utf-8')),
('config_value', String('utf-8')),
('read_only', Boolean),
('config_source', Int8),

This comment has been minimized.

Copy link
@TylerLubeck

TylerLubeck Nov 8, 2019

Author

It looks like this was renamed from is_default to config_source, and the type changed from Boolean to Int8 in v1 as well, but I didn't include that fix here. Should I?

('is_sensitive', Boolean),
('config_synonyms', Array(
('config_name', String('utf-8')),
('config_value', String('utf-8')),
('config_source', Int8)))))))
)

class DescribeConfigsRequest_v0(Request):
API_KEY = 32
API_VERSION = 0
@@ -739,8 +761,15 @@ class DescribeConfigsRequest_v2(Request):
SCHEMA = DescribeConfigsRequest_v1.SCHEMA


DescribeConfigsRequest = [DescribeConfigsRequest_v0, DescribeConfigsRequest_v1]
DescribeConfigsResponse = [DescribeConfigsResponse_v0, DescribeConfigsResponse_v1]
DescribeConfigsRequest = [
DescribeConfigsRequest_v0, DescribeConfigsRequest_v1,
DescribeConfigsRequest_v2,
]
DescribeConfigsResponse = [
DescribeConfigsResponse_v0, DescribeConfigsResponse_v1,
DescribeConfigsResponse_v2,
]


class SaslAuthenticateResponse_v0(Response):
API_KEY = 36
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.