From 98cbc142c0261b75df0e514cabef011c55e092c2 Mon Sep 17 00:00:00 2001
From: David Thomas <dave@davespace.co.uk>
Date: Sat, 10 Feb 2024 11:03:51 +0000
Subject: [PATCH] Add NOT_USEDs

---
 libraries/databases/pickle/test/pickle-test.c    | 2 ++
 libraries/databases/tag-db/test/tag-db-test.c    | 2 ++
 libraries/datastruct/atom/test/atom-test.c       | 2 ++
 libraries/datastruct/bitarr/test/bitarr-test.c   | 3 +++
 libraries/datastruct/bitfifo/test/bitfifo-test.c | 5 +++--
 libraries/datastruct/bitvec/test/bitvec-test.c   | 3 +++
 libraries/datastruct/cache/test/cache-test.c     | 3 +++
 libraries/datastruct/hash/test/hash-test.c       | 2 ++
 libraries/datastruct/list/test/list-test.c       | 2 ++
 libraries/datastruct/ntree/test/ntree-test.c     | 2 ++
 libraries/datastruct/vector/test/vector-test.c   | 2 ++
 libraries/geom/box/test/box-test.c               | 2 ++
 libraries/geom/layout/test/layout-test.c         | 2 ++
 libraries/geom/packer/test/packer-test.c         | 2 ++
 libraries/io/stream/test/stream-test.c           | 2 ++
 libraries/utils/array/test/array-test.c          | 2 ++
 libraries/utils/bsearch/test/bsearch-test.c      | 4 +++-
 17 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/libraries/databases/pickle/test/pickle-test.c b/libraries/databases/pickle/test/pickle-test.c
index 1e264d1..5e15e8a 100644
--- a/libraries/databases/pickle/test/pickle-test.c
+++ b/libraries/databases/pickle/test/pickle-test.c
@@ -599,6 +599,8 @@ result_t pickle_test(const char *resources)
 {
   result_t rc;
 
+  NOT_USED(resources);
+
   printf("test: pickle test 1\n");
 
   rc = pickle__test1_write();
diff --git a/libraries/databases/tag-db/test/tag-db-test.c b/libraries/databases/tag-db/test/tag-db-test.c
index 3af94c1..5ad746f 100644
--- a/libraries/databases/tag-db/test/tag-db-test.c
+++ b/libraries/databases/tag-db/test/tag-db-test.c
@@ -882,6 +882,8 @@ result_t tagdb_test(const char *resources)
   State_t  state;
   int      i;
 
+  NOT_USED(resources);
+
   printf("test: init\n");
 
   err = tagdb_init();
diff --git a/libraries/datastruct/atom/test/atom-test.c b/libraries/datastruct/atom/test/atom-test.c
index 34d7fd9..0fbabed 100644
--- a/libraries/datastruct/atom/test/atom-test.c
+++ b/libraries/datastruct/atom/test/atom-test.c
@@ -199,6 +199,8 @@ result_t atom_test(const char *resources)
   result_t   err;
   atom_set_t *d;
 
+  NOT_USED(resources);
+
   d = atom_create_tuned(1, 12);
   if (d == NULL)
     goto Failure;
diff --git a/libraries/datastruct/bitarr/test/bitarr-test.c b/libraries/datastruct/bitarr/test/bitarr-test.c
index 3342030..91a566b 100644
--- a/libraries/datastruct/bitarr/test/bitarr-test.c
+++ b/libraries/datastruct/bitarr/test/bitarr-test.c
@@ -8,6 +8,7 @@
 #endif
 
 #include "base/result.h"
+#include "base/utils.h"
 #include "datastruct/bitarr.h"
 
 #include "test/all-tests.h"
@@ -39,6 +40,8 @@ result_t bitarr_test(const char *resources)
   testbits_t arr;
   int        i;
 
+  NOT_USED(resources);
+
   printf("test: create\n");
 
   bitarr_wipe(arr, sizeof(arr));
diff --git a/libraries/datastruct/bitfifo/test/bitfifo-test.c b/libraries/datastruct/bitfifo/test/bitfifo-test.c
index cb4a236..d46bf44 100644
--- a/libraries/datastruct/bitfifo/test/bitfifo-test.c
+++ b/libraries/datastruct/bitfifo/test/bitfifo-test.c
@@ -9,6 +9,7 @@
 #endif
 
 #include "base/result.h"
+#include "base/utils.h"
 #include "datastruct/bitfifo.h"
 
 #include "test/all-tests.h"
@@ -30,8 +31,6 @@ expected[] =
   { 32, 0xFFFFFFFF },
 };
 
-#define NELEMS(a) (int)(sizeof(a) / sizeof((a)[0]))
-
 /* shows changes from previous stats */
 static void dump(const bitfifo_t *fifo)
 {
@@ -70,6 +69,8 @@ result_t bitfifo_test(const char *resources)
   int          i;
   unsigned int outbits;
 
+  NOT_USED(resources);
+
   fifo = bitfifo_create(MAXSIZE);
   if (fifo == NULL)
     return result_OOM;
diff --git a/libraries/datastruct/bitvec/test/bitvec-test.c b/libraries/datastruct/bitvec/test/bitvec-test.c
index fed3264..9716545 100644
--- a/libraries/datastruct/bitvec/test/bitvec-test.c
+++ b/libraries/datastruct/bitvec/test/bitvec-test.c
@@ -7,6 +7,7 @@
 #endif
 
 #include "base/result.h"
+#include "base/utils.h"
 #include "datastruct/bitvec.h"
 
 #include "test/all-tests.h"
@@ -30,6 +31,8 @@ result_t bitvec_test(const char *resources)
   bitvec_t *w;
   bitvec_t *x;
 
+  NOT_USED(resources);
+
   printf("test: create\n");
 
   v = bitvec_create(0);
diff --git a/libraries/datastruct/cache/test/cache-test.c b/libraries/datastruct/cache/test/cache-test.c
index 56411b6..0025ca4 100644
--- a/libraries/datastruct/cache/test/cache-test.c
+++ b/libraries/datastruct/cache/test/cache-test.c
@@ -9,6 +9,7 @@
 #endif
 
 #include "base/result.h"
+#include "base/utils.h"
 #include "datastruct/cache.h"
 
 #include "test/all-tests.h"
@@ -25,6 +26,8 @@ result_t cache_test(const char *resources)
   int           nfailures;
   int           i;
 
+  NOT_USED(resources);
+
   config.hash_chain_length   = 4;
   config.nentries_percentage = 25;
 
diff --git a/libraries/datastruct/hash/test/hash-test.c b/libraries/datastruct/hash/test/hash-test.c
index 36a7ca1..7d807b2 100644
--- a/libraries/datastruct/hash/test/hash-test.c
+++ b/libraries/datastruct/hash/test/hash-test.c
@@ -64,6 +64,8 @@ result_t hash_test(const char *resources)
   hash_t  *d;
   int      i;
 
+  NOT_USED(resources);
+
   printf("test: create\n");
 
   /* use default string handling */
diff --git a/libraries/datastruct/list/test/list-test.c b/libraries/datastruct/list/test/list-test.c
index b945209..a6e959c 100644
--- a/libraries/datastruct/list/test/list-test.c
+++ b/libraries/datastruct/list/test/list-test.c
@@ -50,6 +50,8 @@ result_t list_test(const char *resources)
 
   int i;
 
+  NOT_USED(resources);
+
   printf("test: add to head\n");
 
   for (i = 0; i < NELEMS(data); i++)
diff --git a/libraries/datastruct/ntree/test/ntree-test.c b/libraries/datastruct/ntree/test/ntree-test.c
index c8b2df8..6327989 100644
--- a/libraries/datastruct/ntree/test/ntree-test.c
+++ b/libraries/datastruct/ntree/test/ntree-test.c
@@ -211,6 +211,8 @@ result_t ntree_test(const char *resources)
   int      nfailures = 0;
   int      i;
 
+  NOT_USED(resources);
+
   BEGIN_TEST("build tree");
 
   for (i = 0; i < NELEMS(test_data); i++)
diff --git a/libraries/datastruct/vector/test/vector-test.c b/libraries/datastruct/vector/test/vector-test.c
index 3c4b549..2b7ec06 100644
--- a/libraries/datastruct/vector/test/vector-test.c
+++ b/libraries/datastruct/vector/test/vector-test.c
@@ -31,6 +31,8 @@ result_t vector_test(const char *resources)
   int       i;
   int      *p;
 
+  NOT_USED(resources);
+
   printf("test: create\n");
 
   v = vector_create(WIDTH);
diff --git a/libraries/geom/box/test/box-test.c b/libraries/geom/box/test/box-test.c
index c89f705..efd8c69 100644
--- a/libraries/geom/box/test/box-test.c
+++ b/libraries/geom/box/test/box-test.c
@@ -104,6 +104,8 @@ result_t box_test(const char *resources)
   size_t   i;
   int      nfailures;
 
+  NOT_USED(resources);
+
   nfailures = 0;
   for (i = 0; i < NELEMS(tests); i++)
   {
diff --git a/libraries/geom/layout/test/layout-test.c b/libraries/geom/layout/test/layout-test.c
index ddd50ba..b1db833 100644
--- a/libraries/geom/layout/test/layout-test.c
+++ b/libraries/geom/layout/test/layout-test.c
@@ -29,6 +29,8 @@ result_t layout_test(const char *resources)
   box_t         used;
   txtscr_t     *scr;
 
+  NOT_USED(resources);
+
   packer = packer_create(&dims);
   if (packer == NULL)
     goto failure;
diff --git a/libraries/geom/packer/test/packer-test.c b/libraries/geom/packer/test/packer-test.c
index a6186d1..ba744b0 100644
--- a/libraries/geom/packer/test/packer-test.c
+++ b/libraries/geom/packer/test/packer-test.c
@@ -403,6 +403,8 @@ result_t packer_test(const char *resources)
 {
   result_t err;
 
+  NOT_USED(resources);
+
   err = test1();
   if (err)
     goto failure;
diff --git a/libraries/io/stream/test/stream-test.c b/libraries/io/stream/test/stream-test.c
index 7c951c0..21fcae6 100644
--- a/libraries/io/stream/test/stream-test.c
+++ b/libraries/io/stream/test/stream-test.c
@@ -287,6 +287,8 @@ result_t stream_test(const char *resources)
 {
   result_t rc;
 
+  NOT_USED(resources);
+
   rc = test_getc_empty();
   if (rc)
     goto Failure;
diff --git a/libraries/utils/array/test/array-test.c b/libraries/utils/array/test/array-test.c
index c14b213..2b4b176 100644
--- a/libraries/utils/array/test/array-test.c
+++ b/libraries/utils/array/test/array-test.c
@@ -49,6 +49,8 @@ result_t array_test(const char *resources)
   int t;
   int i;
 
+  NOT_USED(resources);
+
 
   printf("test: delete element\n");
 
diff --git a/libraries/utils/bsearch/test/bsearch-test.c b/libraries/utils/bsearch/test/bsearch-test.c
index 6be1edb..f2798af 100644
--- a/libraries/utils/bsearch/test/bsearch-test.c
+++ b/libraries/utils/bsearch/test/bsearch-test.c
@@ -16,10 +16,12 @@
 
 result_t bsearch_test(const char *resources)
 {
+  static const int ints[] = { INT_MIN, INT_MIN + 1, INT_MAX - 1, INT_MAX };
+
   int i;
   int nfailures = 0;
 
-  static const int ints[] = { INT_MIN, INT_MIN + 1, INT_MAX - 1, INT_MAX };
+  NOT_USED(resources);
 
   printf("test: int array\n");