fix(network-manager): support teaming under NM+systemd #1547
Conversation
|
I have tested this locally. |
github-actions
bot
added
modules
| inst_multiple -o \ | ||
| "$systemdsystemunitdir"/teamd@.service \ | ||
| "$dbussystem"/teamd.conf \ | ||
| "$dbussystemconfdir"/teamd.conf |
There was a problem hiding this comment.
@jpirko - the fedora rpm currently defines the dbus conf in /etc/dbus-1/system.d/teamd.conf. Should it be modified to place it in /usr/share/dbus-1/system.d/teamd.conf instead?
Here I'm picking it up from either place in case it changes.
|
cc @bengal |
dustymabe
force-pushed
the
dusty-fix-nm-teaming
branch
2 times, most recently
from
d1263da
to
3777de8
Compare
| @@ -38,6 +38,12 @@ install() { | |||
| inst "$dbussystem"/org.freedesktop.NetworkManager.conf | |||
| inst_multiple nmcli nm-online | |||
|
|
|||
| # teaming support under systemd+dbus | |||
| inst_multiple -o \ | |||
| "$systemdsystemunitdir"/teamd@.service \ | |||
There was a problem hiding this comment.
Currently, NetworkManager spawns teamd directly and then waits that teamd appears on D-Bus to communicate with it.
This line above is not needed because teamd is not started as a systemd service.
The rest LGTM, I also tried the patch and it works well. Thanks!
There was a problem hiding this comment.
fixed in latest push. Thanks @bengal.
Previously when NM was run without dbus then teaming would come up appropriately [1], but now that dbus exists we also need to include some supporting infrastructure to allow for it to work again. [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d689380cfc5734a29b1302d68027190e1a606265
dustymabe
force-pushed
the
dusty-fix-nm-teaming
branch
from
3777de8
to
65ee386
Compare
|
@haraldh - when we merge this do you think we could get it backported to F34? |
Thanks @bengal - any other reviewers we need to wait on or can this be merged now? |
|
Any ideas how to fix the failing |
|
@dustymabe packit tests passing are not a requirement so you can just ignore it. Anyways to fix a failing packit test requires us to open up an issue with the packit team, which then will look into it along with infra with high probability that it's not our PR's causing failure, not packit itself but downstream maintainer or infra making some mistake or upgrade ( this has happened before ). |
Contains upstream fixes needed to get NM running via systemd+dbus in the initramfs without issues. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552 Needed to get dracut unfrozen: coreos/fedora-coreos-tracker#842 (comment)
Contains upstream fixes needed to get NM running via systemd+dbus in the initramfs without issues. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552 Needed to get dracut unfrozen: coreos/fedora-coreos-tracker#842 (comment)
Contains upstream fixes needed to get NM running via systemd+dbus in the initramfs without issues. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552 Needed to get dracut unfrozen: coreos/fedora-coreos-tracker#842 (comment)
Also backport a fix to drop requirement on deprecated systemd-udev-settle. - dracutdevs/dracut#1547 - dracutdevs/dracut#1548 - dracutdevs/dracut#1552
Previously when NM was run without dbus then teaming would come
up appropriately [1], but now that dbus exists we also need to
include some supporting infrastructure to allow for it to work
again.
[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d689380cfc5734a29b1302d68027190e1a606265