90kernel-modules: don't install any block driver if not needed #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If hostonly mode is in use, and there isn't any block device included as hostonly device, then the initramfs won't need any block driver. Eg. for kdump built image, there could be only one nfs mount point, or the initramfs may only execute some network operation then reboot. In such case, skip block driver installation to save space and time. Signed-off-by: Kairui Song <kasong@redhat.com>
|
Hi, @haraldh any thought on this? This help reduces the memory usage for initramfs that will only access the network, which solve some kdump OOM issue. |
|
Can one of the admins verify this patch? |
|
Hi, I have tested it multiple times and so far it worked well, and it can help reduce memory usage in kdump, can any one help give some comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If hostonly mode is in use, and there isn't any block device included
as hostonly device, then the initramfs won't need any block driver.
Eg. for kdump built image, there could be only one nfs mount point,
or the initramfs may only execute some network operation then reboot.
In such case, skip block driver installation to save space and time.
Signed-off-by: Kairui Song kasong@redhat.com