90crypt: pull in remote-cryptsetup.target enablement #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should've been part of dracutdevs#964. As mentioned there, the `initrd-cryptsetup.target` approach was reverted in the end, and we went back to relying in `remote-cryptsetup.target`: systemd/systemd#17467 So we do need to ship the enablement symlink for it.
|
Can one of the admins verify this patch? |
github-actions
bot
added
crypt
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Nov 17, 2020
- Drop the TPM test since it's already covered by the external host test which are inherited from FCOS - Move to new way of defining LUKS devices - Dedupe a bunch of things The test is currently limited to RHCOS but once we have the requisite patches in dracut and systemd in FCOS, we should be able to target it too: dracutdevs/dracut#931 dracutdevs/dracut#968 systemd/systemd#17467
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Nov 18, 2020
- Drop the TPM test since it's already covered by the external host test which are inherited from FCOS - Move to new way of defining LUKS devices - Dedupe a bunch of things The test is currently limited to RHCOS but once we have the requisite patches in dracut and systemd in FCOS, we should be able to target it too: dracutdevs/dracut#931 dracutdevs/dracut#968 systemd/systemd#17467
openshift-merge-robot
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Nov 18, 2020
- Drop the TPM test since it's already covered by the external host test which are inherited from FCOS - Move to new way of defining LUKS devices - Dedupe a bunch of things The test is currently limited to RHCOS but once we have the requisite patches in dracut and systemd in FCOS, we should be able to target it too: dracutdevs/dracut#931 dracutdevs/dracut#968 systemd/systemd#17467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should've been part of #964. As mentioned there, the
initrd-cryptsetup.targetapproach was reverted in the end, and we wentback to relying in
remote-cryptsetup.target:systemd/systemd#17467
So we do need to ship the enablement symlink for it.