New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji plugin raise exeption when number emoji #717

Open
sugarshin opened this Issue Apr 17, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@sugarshin
Copy link
Contributor

sugarshin commented Apr 17, 2017

Hi,

Could you check this. The following emoticons will raise exception.

^:(one|two|three|four|five|six|seven|eight|nine|zero):$

image

I think this is a maybe draft-js issue.

@nikgraf nikgraf added the bug label May 25, 2017

@nikgraf

This comment has been minimized.

Copy link
Member

nikgraf commented May 25, 2017

@bashkos maybe something for you to tackle as you already familiar with the emoji code :)

@bashkos

This comment has been minimized.

Copy link
Collaborator

bashkos commented May 25, 2017

Ok, I'ill see it on this holidays.

@nikgraf

This comment has been minimized.

Copy link
Member

nikgraf commented May 25, 2017

thanks!

@bashkos

This comment has been minimized.

Copy link
Collaborator

bashkos commented May 25, 2017

Maybe it's time to update on EmojiOne 3.x, but it can be so long.

@nikgraf

This comment has been minimized.

Copy link
Member

nikgraf commented May 25, 2017

Just read that EmojiOne 3.x had different license terms :( Makes me want to look for alternatives. Maybe the Twitter set?

@bashkos bashkos self-assigned this May 28, 2017

@bashkos

This comment has been minimized.

Copy link
Collaborator

bashkos commented Jun 17, 2017

With new license terms all of need is attribution, as well as for twemoji. But only emojione provide assort by categories

@gsgilman

This comment has been minimized.

Copy link

gsgilman commented Jul 27, 2017

Any update on the status for this?

@nikgraf

This comment has been minimized.

Copy link
Member

nikgraf commented Aug 11, 2017

@gsgilman didn't get to work on it. are you interested to contribute a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment