New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of emoji-plugin #1042

Merged
merged 2 commits into from Mar 19, 2018

Conversation

Projects
None yet
2 participants
@sugarshin
Copy link
Contributor

sugarshin commented Feb 28, 2018

Checklist

  • Fix any eslint errors that occur
  • Update change-log for every plugin you touch
  • Add/Update tests if you add/change new functionality
  • Add/Update docs if you add/change functionality
  • Enable "Allow edits from maintainers" for this PR

Problem

I fixed some bugs of emoji-plugin.
Maybe this, and the bug of following image.

image

Implementation

I was in reference to implementation of mention-plugin.

onEditorStateChange = (editorState) => {

sugarshin added some commits Feb 28, 2018

@sugarshin sugarshin referenced this pull request Feb 28, 2018

Merged

Fix emoji-plugin #1

@juliankrispel juliankrispel self-requested a review Mar 18, 2018

@juliankrispel

This comment has been minimized.

Copy link
Member

juliankrispel commented Mar 18, 2018

@sugarshin can you clearly tell me how I can reproduce the error your'e fixing here - because I can't reproduce it...

@juliankrispel
Copy link
Member

juliankrispel left a comment

tested and works - thank you!

@juliankrispel
Copy link
Member

juliankrispel left a comment

tested - works fine! thanks @sugarshin

@juliankrispel juliankrispel merged commit 71239c6 into draft-js-plugins:master Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sugarshin

This comment has been minimized.

Copy link
Contributor Author

sugarshin commented Mar 19, 2018

Thanks 🙏
Please also check this. #1028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment