Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix http cache miss for servers which supports etag only #179
Ⅰ. Describe what this PR did
I used harbor as our docker registry, with Dragonfly as a p2p proxy, and I found that supernode has never hit the cache in
It seems that supernode always downloads the blob file again from harbor, even the same file has exist in the
In the method
However, Harbor only returns the
This PR adds support for ETag identifier with http cache.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
@@ Coverage Diff @@ ## master #179 +/- ## ======================================= Coverage 81.43% 81.43% ======================================= Files 28 28 Lines 1282 1282 ======================================= Hits 1044 1044 Misses 207 207 Partials 31 31
wercker/build pipeline is failed, you could rebase from master and push again.