New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom selenium webdriver options via SELENIUM_DRIVER_OPTS #26

Merged
merged 1 commit into from Nov 16, 2014

Conversation

Projects
None yet
2 participants
@zeehio
Copy link
Contributor

zeehio commented Nov 15, 2014

Please consider merging the following patch to django-selenium.
It addresses in a general way issue #16, offering the possibility of passing
custom arguments to the selenium webdriver.

It can be used to pass custom paths for firefox, chromedriver, etc and also
to pass custom options for each webdriver, such as a custom firefox profile.

I have added the respective documentation, to make adoption of the patch
as easy as possible.

Any comments will be very much appreciated. Thank you for your time.

Allow custom selenium webdriver options via SELENIUM_DRIVER_OPTS
SELENIUM_DRIVER_OPTS can be set to a dictionary that will be passed
inside the MyDriver class to the selenium webdriver. This allows
to use django-selenium combined with custom Firefox profiles or
paths in any of the browsers.

This commit preserves backward compatibility with any existing
setup.
@dragoon

This comment has been minimized.

Copy link
Owner

dragoon commented Nov 16, 2014

Hi, thanks for this contribution!
I'm just going to add SELENIUM_DRIVER_OPTS property to the local settings file for consistency.

dragoon added a commit that referenced this pull request Nov 16, 2014

Merge pull request #26 from zeehio/master
Allow custom selenium webdriver options via SELENIUM_DRIVER_OPTS

@dragoon dragoon merged commit 42e982f into dragoon:master Nov 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment