diff --git a/userspace/libsinsp/container_engine/docker.h b/userspace/libsinsp/container_engine/docker.h index a65759043f..8fd656798d 100644 --- a/userspace/libsinsp/container_engine/docker.h +++ b/userspace/libsinsp/container_engine/docker.h @@ -136,6 +136,8 @@ class docker void parse_docker_async(sinsp *inspector, std::string &container_id, sinsp_container_manager *manager); static std::unique_ptr g_docker_info_source; + + static std::string s_incomplete_info_name; }; } } diff --git a/userspace/libsinsp/container_engine/docker_common.cpp b/userspace/libsinsp/container_engine/docker_common.cpp index 24b5b05c06..a1363b4141 100644 --- a/userspace/libsinsp/container_engine/docker_common.cpp +++ b/userspace/libsinsp/container_engine/docker_common.cpp @@ -166,6 +166,8 @@ void docker_async_source::set_query_image_info(bool query_image_info) m_query_image_info = query_image_info; } +std::string docker::s_incomplete_info_name = "incomplete"; + bool docker::resolve(sinsp_container_manager* manager, sinsp_threadinfo* tinfo, bool query_os_for_missing_info) { std::string container_id, container_name; @@ -191,14 +193,14 @@ bool docker::resolve(sinsp_container_manager* manager, sinsp_threadinfo* tinfo, { // Add a minimal container_info object where only the // container id, (possibly) name, and a container - // image=incomplete is filled in. This may be + // image = incomplete is filled in. This may be // overidden later once parse_docker_async completes. sinsp_container_info container_info; container_info.m_type = CT_DOCKER; container_info.m_id = container_id; container_info.m_name = container_name; - container_info.m_image="incomplete"; + container_info.m_image = s_incomplete_info_name; container_info.m_metadata_complete = false; manager->add_container(container_info, tinfo); diff --git a/userspace/libsinsp/container_engine/docker_linux.cpp b/userspace/libsinsp/container_engine/docker_linux.cpp index 0de85329e6..acb5f5cafb 100644 --- a/userspace/libsinsp/container_engine/docker_linux.cpp +++ b/userspace/libsinsp/container_engine/docker_linux.cpp @@ -171,7 +171,7 @@ bool docker::detect_docker(const sinsp_threadinfo *tinfo, std::string &container if(matches_runc_cgroups(tinfo, DOCKER_CGROUP_LAYOUT, container_id)) { // The container name is only available in windows - container_name = "incomplete"; + container_name = s_incomplete_info_name; return true; }