Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Investigate why Travis is broken? #392

Closed
steveklabnik opened this Issue · 9 comments

3 participants

@steveklabnik

I get all passing locally, but Travis says we're failing: https://travis-ci.org/drapergem/draper/builds/3717738 and a rebuild https://travis-ci.org/drapergem/draper/builds/3717738

:'(

Do the tests run for you, @nashby @haines ?

@nashby
Collaborator
@nashby
Collaborator
@nashby
Collaborator
@steveklabnik

Ahhhhhhhhh. Let me tie down that version, then, and investigate.

@steveklabnik

Right, so this should not affect Draper users at all, just our tests. Until they're updated, I'm locking the version to 1.0.1, which is the one I'm using locally.

@steveklabnik

Our integration tests app isn't picking up the middleware for some reason.

@steveklabnik steveklabnik referenced this issue in steveklabnik/request_store
Closed

Possible issue with Railtie inclusion #8

@steveklabnik

Okay, this is locked down so our tests pass, but this is a bug in request_store. I've filed one over there.

@steveklabnik

@haines made a good point, this is our fault: steveklabnik/request_store#8 (comment)

@steveklabnik steveklabnik reopened this
@haines
Collaborator

As @elado points out in #396, this issue breaks Draper on the console as well as in tests. I've tested my fix (steveklabnik/request_store#11) and it works for both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.