Refactor of method_missing on Draper::Base for ease of reading #137

Merged
merged 3 commits into from Mar 3, 2012

Conversation

Projects
None yet
2 participants
@markburns
Contributor

markburns commented Mar 3, 2012

I think this tidies up the method slightly, separating Exception handling and moving to the bottom of the method, exiting early unless allowed and reducing nesting. Also removing superfluous self when calling the newly defined method.

The specs are passing.

steveklabnik added a commit that referenced this pull request Mar 3, 2012

Merge pull request #137 from markburns/master
Refactor of method_missing on Draper::Base for ease of reading

@steveklabnik steveklabnik merged commit d6e361b into drapergem:master Mar 3, 2012

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 3, 2012

Owner

I like it! Thank you.

Owner

steveklabnik commented Mar 3, 2012

I like it! Thank you.

@markburns

This comment has been minimized.

Show comment Hide comment
@markburns

markburns Mar 3, 2012

Contributor

You're welcome. By the way, I'll see you in Poland next weekend.

Contributor

markburns commented Mar 3, 2012

You're welcome. By the way, I'll see you in Poland next weekend.

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 3, 2012

Owner

:) That's such a fun sentence to hear... heh.

Owner

steveklabnik commented Mar 3, 2012

:) That's such a fun sentence to hear... heh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment