Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add a helper method sign_in for devise in decorator specs. #383

Merged
merged 1 commit into from Dec 13, 2012

Conversation

Projects
None yet
3 participants
Contributor

vizjerai commented Dec 12, 2012

This allows current_user to be set for Devise in decorator tests in RSpec. See #363 for details.

Owner

steveklabnik commented Dec 12, 2012

🤘 Thank you!

Before I merge, though: Wouldn't this make more sense in the Railtie, since it relies on a gem? We wouldn't want the same issue we had with Capybara.

Member

nashby commented Dec 12, 2012

@steveklabnik maybe it makes sense to create a separate gem for it? I don't think we can support all kind of gems in draper core...

Contributor

vizjerai commented Dec 12, 2012

Yes, but the require for this file is already in a railtie. So the Capybara one really doesn't need to be there anymore.

Owner

steveklabnik commented Dec 12, 2012

@vizjerai Okay, that does make sense.

@nashby as always, yeah, it's a balance between having just draper and a zillion draper- gems. Hrm.

steveklabnik added a commit that referenced this pull request Dec 13, 2012

Merge pull request #383 from vizjerai/devise
Add a helper method sign_in for devise in decorator specs.

@steveklabnik steveklabnik merged commit 0e51d1d into drapergem:master Dec 13, 2012

1 check passed

default The Travis build passed
Details
Owner

steveklabnik commented Dec 13, 2012

I think that for now, Devise is popular enough that we should make us work with it. If this gets too out of hand, we can talk about splitting things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment