Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use `self == other.source` in Decoratable#== #404

Merged
merged 1 commit into from Dec 28, 2012

Conversation

Projects
None yet
3 participants
Contributor

haines commented Dec 28, 2012

Apparently AR::Base does something tricky with #== which causes super(other.source) to break when comparing a model to a decorator that wraps a different instance of the same model. Weird.

I added an integration spec for that case.

Closes #391.

@haines haines Use `self == other.source` in Decoratable#==
Apparently AR::Base does something tricky with #== which causes
`super(other.source)` to break

Closes #391
b83a95f

@haines haines referenced this pull request Dec 28, 2012

Closed

Draper::Decoratable#== #391

Owner

steveklabnik commented Dec 28, 2012

I added an integration spec for that case.

❤️ ❤️ ❤️ I need to get better at doing these.

@steveklabnik steveklabnik added a commit that referenced this pull request Dec 28, 2012

@steveklabnik steveklabnik Merge pull request #404 from haines/equality
Use `self == other.source` in Decoratable#==
e4fa239

@steveklabnik steveklabnik merged commit e4fa239 into drapergem:master Dec 28, 2012

1 check passed

default The Travis build passed
Details

@haines haines deleted the unknown repository branch Dec 29, 2012

Contributor

tovodeverett commented Dec 31, 2012

I'm currently running from c6d60e6 without any issues (I just had to pull my monkey patch and everything was good). 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment