Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed minitest helper to test_helper #570

Merged
merged 1 commit into from Nov 13, 2013

Conversation

Linuus
Copy link
Contributor

@Linuus Linuus commented Aug 14, 2013

The minitest helper is not called minitest_helper anymore but test_helper instead.
See: https://github.com/blowmage/minitest-rails/wiki/Upgrading-to-0.9

@steveklabnik
Copy link
Member

Does this mean we're incompatible with older versions of minit-test rails after this change?

@Linuus
Copy link
Contributor Author

Linuus commented Aug 14, 2013

Well... In version below minitest-rails 0.9 the helper file is called minitest_helper.rb by default. But it can be called anything :) But since 0.9 the default is test_helper.rb just as Rails has it by default with test/unit.

Anyway... I guess we can check the version of minitest-rails and then include either minitest_helper if below 0.9 or test_helper otherwise.

@steveklabnik
Copy link
Member

What do you think, @blowmage?

@zerobearing2
Copy link

any chance this'll get merged? I'd like to clean up my project DEPRECATION WARNING's. 👍

@steveklabnik
Copy link
Member

I still haven't heard from @blowmage about compatibility.

@blowmage
Copy link
Contributor

I would accept this. 👍

steveklabnik added a commit that referenced this pull request Nov 13, 2013
Renamed minitest helper to test_helper
@steveklabnik steveklabnik merged commit 407e59c into drapergem:master Nov 13, 2013
@steveklabnik
Copy link
Member

Done and done. Thanks. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants