From 4634c2004cf05e5e4667e78f5f458a4290cb249a Mon Sep 17 00:00:00 2001 From: Eric Hodel Date: Tue, 4 Oct 2016 20:41:36 -0700 Subject: [PATCH] Restore support for String as URI for #request --- lib/net/http/persistent.rb | 1 + test/test_net_http_persistent.rb | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/lib/net/http/persistent.rb b/lib/net/http/persistent.rb index 9e26491..338ca9e 100644 --- a/lib/net/http/persistent.rb +++ b/lib/net/http/persistent.rb @@ -1012,6 +1012,7 @@ def request uri, req = nil, &block retried = false bad_response = false + uri = URI uri req = request_setup req || uri response = nil diff --git a/test/test_net_http_persistent.rb b/test/test_net_http_persistent.rb index e1001f3..551d1e2 100644 --- a/test/test_net_http_persistent.rb +++ b/test/test_net_http_persistent.rb @@ -1350,6 +1350,22 @@ def test_request_setup assert_equal '30', req['keep-alive'] end + def test_request_string + @http.override_headers['user-agent'] = 'test ua' + @http.headers['accept'] = 'text/*' + c = connection + + res = @http.request @uri.to_s + req = c.http.req + + assert_kind_of Net::HTTPResponse, res + + assert_kind_of Net::HTTP::Get, req + assert_equal '/path', req.path + + assert_equal 1, c.requests + end + def test_request_setup_uri uri = @uri + '?a=b'