Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes a bug in shutdown, unsure of exact minimal replication case #24

Merged
merged 1 commit into from Oct 17, 2012

Conversation

Projects
None yet
4 participants

We're seeing this too. I'd love to get this in.

This occurs when shutdown is called without any connections having been made. So, minimal replication case:

Net::HTTP::Persistent.new.shutdown # NoMethodError: undefined method `delete' for nil:NilClass

@drbrain drbrain added a commit that referenced this pull request Oct 17, 2012

@drbrain drbrain Merge pull request #24 from raggi/shutdown_bug
Fixes a bug in shutdown, unsure of exact minimal replication case
be08c31

@drbrain drbrain merged commit be08c31 into drbrain:master Oct 17, 2012

@drbrain drbrain added a commit that referenced this pull request Oct 17, 2012

@drbrain drbrain Updated History.txt for #28 and #24 7d12277

@drbrain drbrain added a commit that referenced this pull request Oct 17, 2012

@drbrain drbrain Updated #shutdown test for #24 07b4092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment