added correct NSImage icon support #10

Merged
merged 1 commit into from Feb 12, 2014

Conversation

Projects
None yet
3 participants
Run options: 

# Running tests:

...............................................S.S.....

Finished tests in 1.075285s, 51.1492 tests/s, 136.7079 assertions/s.

  1) Skipped:
test_notify_priority(TestGrowlUDP) [/Volumes/Users/barry/github/steakknife/ruby-growl/test/test_growl_udp.rb:27]:
Errno::ECONNREFUSED: Connection refused - send(2)

  2) Skipped:
test_notify_notify_type(TestGrowlUDP) [/Volumes/Users/barry/github/steakknife/ruby-growl/test/test_growl_udp.rb:39]:
Errno::ECONNREFUSED: Connection refused - send(2)

55 tests, 147 assertions, 0 failures, 0 errors, 2 skips

This pull request fails (merged e86a31d into 3e252e6).

This pull request fails (merged ec23843 into 3e252e6).

added correct NSImage icon support
silence

added -i icon argument

fixed manifest

hostname -> host for mri==1.9.2

This pull request passes (merged 8cc364b into 3e252e6).

This open PR branch still works. Interesting.

drbrain added a commit that referenced this pull request Feb 12, 2014

@drbrain drbrain merged commit 8e9abff into drbrain:master Feb 12, 2014

1 check passed

default The Travis build passed
Details

drbrain added a commit that referenced this pull request Feb 12, 2014

GNTP#load_resource now loads based on scheme
This allows the tests to use file:// URIs so I don't have to worry about
them hitting the network and being slow or for the http:// URI in the
tests to go away.

See #10

drbrain added a commit that referenced this pull request Feb 12, 2014

Owner

drbrain commented Feb 13, 2014

Oops, I mis-tagged @86c1eeb for the wrong issue.

It looks like the main purpose of this pull request was for --icon with a URL. The URL portion was already supported in ruby-growl so I changed the --icon handling code to return a URI object instead of a string which allowed removal of #load_resource (as growl will fetch the URL for us).

Did I miss something important with #load_resource?

drbrain added a commit that referenced this pull request Feb 13, 2014

Looks better, thanks.  It was hacky PoC code.—
Sent from Mailbox for iPhone

On Thu, Feb 13, 2014 at 2:50 PM, Eric Hodel notifications@github.com
wrote:

Oops, I mis-tagged @86c1eeb for the wrong issue.
It looks like the main purpose of this pull request was for --icon with a URL. The URL portion was already supported in ruby-growl so I changed the --icon handling code to return a URI object instead of a string which allowed removal of #load_resource (as growl will fetch the URL for us).

Did I miss something important with #load_resource?

Reply to this email directly or view it on GitHub:
#10 (comment)

Owner

drbrain commented Feb 14, 2014

No problem! It took me a while to remember the feature existed.

drbrain added a commit that referenced this pull request Feb 14, 2014

Remove old rubygems .source_index
This was inadvertently added with #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment